Skip to content

Commit 9fdd6b6

Browse files
committed
build+docs: use Python 3.8 - 3.11 and pin pytest 8.1.1
- `conda create -n plotly-dev python` currently gives Python 3.12.3. - `pytest -v packages/python/plotly/plotly/tests/` then fails with `ModuleNotFoundError: No module named 'imp'`. - `pip install imp` fails: the `imp` module was deprecated in Python 3.11 and has been removed in Python 3.12. - So update `contributing.md` to specify `conda create -n plotly-dev python=3.11` - But now `pytest` fails - `File "<frozen importlib._bootstrap>", line 1072, in _find_spec` - `AttributeError: 'AssertionRewritingHook' object has no attribute 'find_spec'` - Problem was `pytest==3.5.1` in `packages/python/plotly/optional-requirements.txt` - Update to `pytest==8.1.1` and `pytest` runs - Some tests are failing (orca problems, `statsmodels` not installed, etc.) - Will fix these in separate PRs - Update `contributing.md` to state that we've tested changes against Python 3.8-3.11 - Specifically 3.8.19, 3.9.19, 3.10.14, and 3.11.9 on MacOS Sonoma 14.4.1 - Update `CHANGELOG.md`
1 parent 91aa1c9 commit 9fdd6b6

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22
All notable changes to this project will be documented in this file.
33
This project adheres to [Semantic Versioning](http://semver.org/).
44

5+
## [5.23.0] - TBD
6+
7+
### Updated
8+
- Specify Python version 3.8-3.11 for development virtual environments and pin `pytest` at version 8.1.1 to match.
9+
510
## [5.22.0] - 2024-05-01
611

712
### Updated

contributing.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,16 @@ learn and become confident about git, like http://try.github.io/.
125125

126126
### Create a virtual environment for plotly development
127127

128-
You can use either [conda][conda-env] or [virtualenv][virtualenv] to create a virtual environment for plotly development, e.g.
128+
You can use either [conda][conda-env] or [virtualenv][virtualenv] to create a virtual environment for plotly development, e.g.:
129129

130130
```bash
131-
conda create -n plotly-dev python
131+
conda create -n plotly-dev python=3.11
132132
conda activate plotly-dev
133133
```
134134

135+
As of May 2024 our dependencies have been tested against Python versions 3.8 to 3.11.
136+
We will support Python 3.12 and higher versions soon.
137+
135138
[conda-env]: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-with-commands
136139
[virtualenv]: http://docs.python-guide.org/en/latest/dev/virtualenvs/
137140

packages/python/plotly/optional-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ numpy
1414
## testing dependencies ##
1515
coverage==4.3.1
1616
mock==2.0.0
17-
pytest==3.5.1
17+
pytest==8.1.1
1818
backports.tempfile==1.0
1919
xarray
2020
pytz

0 commit comments

Comments
 (0)