[fix] Guideline stat API refactoring

It is a wanted fix. The purpose of this PR to get rid of the severity of Rule struct to get a better form. I think it needs more API endpoint calls and it gets slower but the Guideline stat endpoint is pretty at least.

Author: cservakt

web/api/js/codechecker-api-node/dist/codechecker-api-6.60.0.tgz

@@ -553,10 +553,10 @@ struct Guideline {
 }
 
 struct Rule {
-  1: string ruleId,                     // The identifier of the rule.
-  2: string title,                      // The rule summary.
-  3: string url,                        // The link of the rule page.
-  4: list<map<string, string>> checkers // List of checker names
+  1: string ruleId,        // The identifier of the rule.
+  2: string title,         // The rule summary.
+  3: string url,           // The link of the rule page.
+  4: list<string> checkers // List of checker names
 }
 typedef map<string, list<Rule>> GuidelineRules
 

web/api/py/codechecker_api/dist/codechecker_api.tar.gz

@@ -2790,13 +2790,8 @@ def getGuidelineRules(
                 guideline_rules[guideline.guidelineName] = []
                 continue
             for rule in rules:
-                checkers = [{
-                    "checkerName": checker_name,
-                    "severity": self._context.checker_labels.severity(
-                        checker_name).lower()
-                    } for checker_name in
-                            self._context.checker_labels.checkers_by_labels(
-                                [f"{guideline.guidelineName}:{rule}"])]
+                checkers = self._context.checker_labels.checkers_by_labels(
+                    [f"{guideline.guidelineName}:{rule}"])
 
                 guideline_rules[guideline.guidelineName].append(
                     Rule(

web/api/py/codechecker_api_shared/dist/codechecker_api_shared.tar.gz

@@ -131,6 +131,7 @@ import { BaseStatistics } from "@/components/Statistics";
 import GuidelineStatisticsTable from "./GuidelineStatisticsTable";
 import StatisticsDialog from "../StatisticsDialog";
 import {
+  Checker,
   Guideline,
   MAX_QUERY_SIZE,
   ReportFilter,
@@ -304,9 +305,52 @@ export default {
       this.all_guideline_rules = await new Promise(resolve => {
         ccService.getClient().getGuidelineRules(
           this.selectedGuidelines,
-          handleThriftError(guidelines => {
+          handleThriftError(async guidelines => {
+            for (const [ guideline, rules ] of Object.entries(guidelines)) {
+              guidelines[guideline] = await Promise.all(
+                rules.map(async rule => {
+                  const checkers = await Promise.all(
+                    rule.checkers.map(async checker => {
+                      const severity = await new Promise(resolve => {
+                        ccService.getClient().getCheckerLabels(
+                          [
+                            new Checker({
+                              analyzerName: null,
+                              checkerId: checker
+                            })
+                          ],
+                          handleThriftError(labels => {
+                            const severityLabels = labels[0].filter(param =>
+                              param.startsWith("severity")
+                            );
+                            const severity = severityLabels.length
+                              ? severityLabels[0].split("severity:")[1]
+                              : null;
+                            resolve(severity);
+                          })
+                        );
+                      });
+
+                      return {
+                        checkerName: checker,
+                        severity: severity
+                      };
+                    })
+                  );
+
+                  return {
+                    ruleId: rule.ruleId,
+                    title: rule.title,
+                    url: rule.url,
+                    checkers: checkers
+                  };
+                })
+              );
+            }
+
             resolve(guidelines);
-          }));
+          })
+        );
       });
     },
 

web/api/report_server.thrift

@@ -470,8 +470,5 @@ def test_get_guideline_rules(self):
                                       sei_cert_rules))[0]
         self.assertEqual(len(con_54_cpp_rule.checkers), 1)
 
-        releated_checker = {
-            "checkerName": "bugprone-spuriously-wake-up-functions",
-            "severity": "medium"
-        }
-        self.assertEqual(con_54_cpp_rule.checkers, [releated_checker])
+        self.assertEqual(con_54_cpp_rule.checkers,
+                         ["bugprone-spuriously-wake-up-functions"])