feat: make API keys work with all portal methods #1186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should do all of the work to resolve #1182.
There should be no breaking changes because of this work.
In most cases this could be made to work async via a new
determineUsername()
function which uses.getUsername()
internally. All authentication mangers now extend a base class which impliments username fetching and caching.Some cases like
getSharingUrl()
orisItemOwner()
which are public synchronous methods cannot be modified to be async so tey where modified to accept ausername
param as a second argument which usesgetUsername()
in the async functions that use them. These should still work as implemented if people continue to use them withArcGISIdentityManager
but might not work with API keys.In our next breaking change we should:
username
entirely to force use ofgetUsername()