Skip to content

Commit ef8fc51

Browse files
committed
Fix missed up violations by checkstyle.
1 parent 7255d74 commit ef8fc51

File tree

3 files changed

+21
-18
lines changed

3 files changed

+21
-18
lines changed

config/checkstyle/suppressions.xml

+3
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,7 @@
44
"http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
55
<suppressions>
66
<suppress checks="EmptyLineSeparator" files="Translation.java"/>
7+
<suppress checks="RequireThis" files=".*[\\/]test[\\/]"/>
8+
<suppress checks="AvoidStarImport" files=".*[\\/]test[\\/]"/>
9+
<suppress checks="WhitespaceAround" files=".*[\\/]test[\\/]"/>
710
</suppressions>

eternalcore-plugin/src/main/java/com/eternalcode/core/loader/dependency/DependencyLoaderImpl.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public class DependencyLoaderImpl implements DependencyLoader {
3232
private final Map<Dependency, Path> loaded = new HashMap<>();
3333

3434
public DependencyLoaderImpl(Logger logger, File dataFolder, List<Repository> repositories) {
35-
Path localRepositoryPath = setupCacheDirectory(dataFolder);
35+
Path localRepositoryPath = this.setupCacheDirectory(dataFolder);
3636
Repository localRepository = Repository.localRepository(localRepositoryPath);
3737

3838
List<Repository> allRepositories = new ArrayList<>();

eternalcore-plugin/src/main/java/com/eternalcode/core/loader/pom/PomXmlScanner.java

+17-17
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,24 @@
44
import com.eternalcode.core.loader.dependency.DependencyCollector;
55
import com.eternalcode.core.loader.repository.Repository;
66
import java.io.File;
7-
import java.net.URISyntaxException;
8-
import java.nio.file.Files;
9-
import java.nio.file.StandardCopyOption;
10-
import org.w3c.dom.Document;
11-
import org.w3c.dom.Element;
12-
import org.w3c.dom.NodeList;
13-
import org.xml.sax.SAXException;
14-
15-
import javax.xml.XMLConstants;
16-
import javax.xml.parsers.DocumentBuilder;
17-
import javax.xml.parsers.DocumentBuilderFactory;
18-
import javax.xml.parsers.ParserConfigurationException;
197
import java.io.IOException;
208
import java.io.InputStream;
9+
import java.net.URISyntaxException;
2110
import java.net.URL;
11+
import java.nio.file.Files;
12+
import java.nio.file.StandardCopyOption;
2213
import java.util.ArrayList;
2314
import java.util.Collections;
2415
import java.util.List;
2516
import java.util.Optional;
17+
import javax.xml.XMLConstants;
18+
import javax.xml.parsers.DocumentBuilder;
19+
import javax.xml.parsers.DocumentBuilderFactory;
20+
import javax.xml.parsers.ParserConfigurationException;
21+
import org.w3c.dom.Document;
22+
import org.w3c.dom.Element;
23+
import org.w3c.dom.NodeList;
24+
import org.xml.sax.SAXException;
2625

2726
public class PomXmlScanner implements DependencyScanner {
2827

@@ -37,7 +36,8 @@ public class PomXmlScanner implements DependencyScanner {
3736
DOCUMENT_BUILDER_FACTORY.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
3837
DOCUMENT_BUILDER_FACTORY.setXIncludeAware(false);
3938
DOCUMENT_BUILDER_FACTORY.setExpandEntityReferences(false);
40-
} catch (ParserConfigurationException exception) {
39+
}
40+
catch (ParserConfigurationException exception) {
4141
throw new RuntimeException("Failed to configure XML parser", exception);
4242
}
4343
}
@@ -83,14 +83,14 @@ private Optional<List<Dependency>> tryReadDependency(Dependency dependency, Repo
8383
List<Dependency> dependencies = this.readDependency(pomXml);
8484

8585
return Optional.of(dependencies);
86-
8786
}
8887
catch (IOException | SAXException | ParserConfigurationException | URISyntaxException exception) {
8988
return Optional.empty();
9089
}
9190
}
9291

93-
private File savePomXmlToLocalRepository(Dependency dependency, Repository repository) throws URISyntaxException, IOException {
92+
private File savePomXmlToLocalRepository(Dependency dependency, Repository repository)
93+
throws URISyntaxException, IOException {
9494
File localFile = dependency.toPomXml(this.localRepository).toFile();
9595

9696
if (localFile.exists() && !this.isEmpty(localFile)) {
@@ -110,7 +110,8 @@ private File savePomXmlToLocalRepository(Dependency dependency, Repository repos
110110
private boolean isEmpty(File file) {
111111
try {
112112
return Files.size(file.toPath()) == 0;
113-
} catch (IOException exception) {
113+
}
114+
catch (IOException exception) {
114115
return true;
115116
}
116117
}
@@ -163,5 +164,4 @@ private List<Dependency> readDependency(File file) throws ParserConfigurationExc
163164

164165
return Collections.unmodifiableList(dependencies);
165166
}
166-
167167
}

0 commit comments

Comments
 (0)