diff --git a/deliveries/polkadot-desktop-app-milestone-3.md b/deliveries/polkadot-desktop-app-milestone-3.md new file mode 100644 index 000000000..df1c56819 --- /dev/null +++ b/deliveries/polkadot-desktop-app-milestone-3.md @@ -0,0 +1,70 @@ +# Milestone Delivery :mailbox: + +**The [invoice form :pencil:](https://docs.google.com/forms/d/e/1FAIpQLSfmNYaoCgrxyhzgoKQ0ynQvnNRoTmgApz9NrMp-hd8mhIiO0A/viewform) has been filled out correctly for this milestone and the delivery is according to the official [milestone delivery guidelines](https://github.com/w3f/Grants-Program/blob/master/docs/milestone-deliverables-guidelines.md).** + +* **Application Document:** [link](https://github.com/w3f/Grants-Program/blob/master/applications/polkadot-desktop-app.md) +* **Milestone Number:** 3 + +## Visual summary of the changes + +| | Before | After | +| ------- | -------| ----- | +| Accounts | ![image](https://user-images.githubusercontent.com/430616/137498444-0ead994f-a541-482d-a9cb-62c7aeb09918.png) | ![image](https://user-images.githubusercontent.com/430616/137498472-52ab3a62-8eb7-4afc-894e-a1768c68427f.png) | +| Popup | ![image](https://user-images.githubusercontent.com/430616/137498521-c03a3c56-79c0-4990-80f4-3f51c13d349a.png) | ![image](https://user-images.githubusercontent.com/430616/137498539-ecc5afa1-d2bf-4db3-bf87-08b5cd9318ab.png) | +| Sidebar | ![image](https://user-images.githubusercontent.com/430616/137497848-c3e86adc-c713-4313-9e68-d5503089ad1b.png) | ![image](https://user-images.githubusercontent.com/430616/137497997-973064d3-8941-4d70-a954-01a54b215078.png) | + +## Detailed delivery description + +| Number | Deliverable | Link | Notes | +| --- | -------------------------------- | ------------- |------ | +| 1. | Accounts list redesign | [Figma designs][figma-designs] | Also includes proposed design for network multi-selection per account in extension and apps (see [#5439][apps-5439]) | +| 2. | Accounts list implementation | New designs are applied to [Accounts][app-accounts] and [Address book][app-address-book].
Source code changes mainly in [App Accounts][code-accounts] - consult PRs for details.
Automated tests - primarily in [App Accounts][code-accounts-tests], applied also to Address Book - consult PRs for details. |
  1. [Summary bar][pr-summary-bar] + [styles][pr-summary-bar-styles] (still open)
  2. [Tag styles][pr-tag-styles]
  3. [Account collapsible details row][pr-row-details]
  4. [Style address balances][pr-style-address-balances]
  5. [Add accounts sorting][pr-accounts-sorting]
  6. [Replace SUI popup with custom one][pr-replace-sui-popup]
  7. [Display parent above account name][pr-display-parent]
  8. [Account actions popup redesign][pr-accounts-popup]
  9. [Explorer links placement][pr-accounts-buttons]
  10. [Add hover to expand button][pr-expand-hover]
  11. [Account filter placement][pr-move-filter-input]
  12. [Style sort input][pr-sort-style]
  13. [Apply table style to Address Book][pr-row-details-addresses]
  14. [Apply button and filter styles to Address Book][pr-filter-addresses]
  15. [Correct row coloring when filtering][pr-filtering-bugfix]
  16. [Style account badges][pr-badges]
  17. [Style table headers][pr-table-headers] (still open)
  18. [Style redeemable balances in expanded view][pr-redeemable]
      19. | +| 3. | Accounts sidebar implementation | Click on any account in [apps][app].
      Source code changes mainly in [Sidebar][code-sidebar] - consult PRs for details.
      Automated tests in [Sidebar.spec][code-sidebar-tests] |
      1. [Split judgements per registrar][pr-registrars] (closes long outstanding [issue][apps-2297-registrars])
      2. [Accounts flags placement][pr-flags-width]
      3. [Icons for explorer links][pr-sidebar-links]
      4. [Style flags][pr-sidebar-flags]
      5. [Edit name and tags][pr-sidebar-edit]
      6. [Style identity and balances sections][pr-sidebar-identity]
      7. [Increase width][pr-sidebar-width]
      8. [Style upper part][pr-sidebar-style-upper]
      | +| 4. | Accounts App modals improvements | Try interacting with "Create account" modal on [Accounts page][app-accounts] with `Esc` and `Enter`. Other changes are mostly low-level in code, consult PRs for details.|
      1. [Create/derive - remove code duplication][pr-modals-duplication]
      2. [Replace SUI modals with custom ones][pr-replace-sui-modal]
      3. [Support keyboard in modals][pr-keyboard-in-modal]
      | +| 5. | Documentation updates | Updates in [Multisig section][doc-multisig] of the wiki | [PR #2724][pr-doc-multisig] in wiki repo. | + +Most of the PRs listed include automated tests. + +[app]: https://polkadot.js.org/apps +[app-accounts]: https://polkadot.js.org/apps/#/accounts +[app-address-book]: https://polkadot.js.org/apps/#/addresses +[figma-designs]: https://www.figma.com/file/5NAICV06SHNbbIoYhrUS3u/PolkaDot?node-id=2839%3A8075 +[code-accounts]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.tsx +[code-accounts-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Accounts/index.spec.ts +[code-sidebar-tests]: https://github.com/polkadot-js/apps/blob/master/packages/page-accounts/src/Sidebar/Sidebar.spec.tsx +[pr-summary-bar]: https://github.com/polkadot-js/apps/pull/5876 +[pr-summary-bar-styles]: https://github.com/polkadot-js/apps/pull/5891 +[pr-tag-styles]: https://github.com/polkadot-js/apps/pull/5893 +[pr-row-details]: https://github.com/polkadot-js/apps/pull/5975 +[pr-modals-duplication]: https://github.com/polkadot-js/apps/pull/5895 +[apps-5439]: https://github.com/polkadot-js/apps/issues/5439 +[pr-style-address-balances]: https://github.com/polkadot-js/apps/pull/5897 +[pr-replace-sui-modal]: https://github.com/polkadot-js/apps/pull/5914 +[pr-accounts-sorting]: https://github.com/polkadot-js/apps/pull/5923 +[pr-replace-sui-popup]: https://github.com/polkadot-js/apps/pull/5924 +[pr-display-parent]: https://github.com/polkadot-js/apps/pull/5947 +[pr-keyboard-in-modal]: https://github.com/polkadot-js/apps/pull/5968 +[code-sidebar]: https://github.com/polkadot-js/apps/tree/master/packages/page-accounts/src/Sidebar +[pr-flags-width]: https://github.com/polkadot-js/apps/pull/5957 +[pr-sidebar-links]: https://github.com/polkadot-js/apps/pull/5999 +[pr-sidebar-flags]: https://github.com/polkadot-js/apps/pull/6003 +[pr-accounts-popup]: https://github.com/polkadot-js/apps/pull/6007 +[pr-accounts-buttons]: https://github.com/polkadot-js/apps/pull/6012 +[pr-sidebar-edit]: https://github.com/polkadot-js/apps/pull/6049 +[pr-expand-hover]: https://github.com/polkadot-js/apps/pull/6052 +[pr-move-filter-input]: https://github.com/polkadot-js/apps/pull/6089 +[pr-sidebar-identity]: https://github.com/polkadot-js/apps/pull/6096 +[pr-sort-style]: https://github.com/polkadot-js/apps/pull/6099 +[pr-sidebar-width]: https://github.com/polkadot-js/apps/pull/6104 +[pr-sidebar-style-upper]: https://github.com/polkadot-js/apps/pull/6115 +[pr-row-details-addresses]: https://github.com/polkadot-js/apps/pull/6122 +[pr-filter-addresses]: https://github.com/polkadot-js/apps/pull/6155 +[pr-tests-output]: https://github.com/polkadot-js/apps/pull/6132 +[pr-filtering-bugfix]: https://github.com/polkadot-js/apps/pull/6166 +[pr-registrars]: https://github.com/polkadot-js/apps/pull/6157 +[apps-2297-registrars]: https://github.com/polkadot-js/apps/issues/2297 +[pr-badges]: https://github.com/polkadot-js/apps/pull/6208 +[pr-table-headers]: https://github.com/polkadot-js/apps/pull/6180 +[pr-redeemable]: https://github.com/polkadot-js/apps/pull/6220 +[doc-multisig]: https://wiki.polkadot.network/docs/learn-accounts#example-with-polkadotjs +[pr-doc-multisig]: https://github.com/w3f/polkadot-wiki/pull/2724