Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read .geom file written by GenericGeometry #113

Open
JunCEEE opened this issue Oct 1, 2021 · 2 comments
Open

Read .geom file written by GenericGeometry #113

JunCEEE opened this issue Oct 1, 2021 · 2 comments

Comments

@JunCEEE
Copy link
Contributor

JunCEEE commented Oct 1, 2021

Hi,

I know there is currently no support for reading a generic crystfel geom file, but could we at least support reading the .geom file writtern by the GenericGeometry class?

@takluyver
Copy link
Member

That's probably fine so long as the limitation is documented. It would be kind of fiddly to implement, though.

I've wondered about having another file format based around what EXtra-geom stores, so we could easily & reliably read & write files, rather than having a lot of fiddly translations. I don't really want to add yet another file format, though. Maybe it could be done as an extension of the EuXFEL HDF5 geometry format.

It should be possible to use pickle for short-term storage of geometry objects (e.g. to transfer to a worker process). Don't rely on this format for long term storage, though - objects pickled from one version of EXtra-geom are likely to break with some future version.

@JunCEEE
Copy link
Contributor Author

JunCEEE commented Oct 5, 2021

Thank you @takluyver. In SimEx-Lite, we need to save the necessary parameters/data in .json file for an instrument database, so that others can download the instrument setup can run it easily. I thought since the multi-panel geometry is a bit complicated, maybe I can store the geometry in crystFEL format. As you mentioned, the function could be fiddly to add. Do you think there could be a better way to store the geometry parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants