Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests!!! #11

Open
ExpandingMan opened this issue Mar 2, 2018 · 4 comments
Open

add unit tests!!! #11

ExpandingMan opened this issue Mar 2, 2018 · 4 comments

Comments

@ExpandingMan
Copy link
Owner

We need proper unit testing so that we can make changes and merge PR's properly. I'll try to get to this right after I do 0.7 updates.

@ExpandingMan
Copy link
Owner Author

Have added some fairly extensive unit tests that mostly test whether getindex and various ArrowVector constructors are working properly. Still need to add more, particularly for writing data.

@davidanthoff
Copy link
Contributor

Just to second that, code coverage right now is sparse :)

https://codecov.io/gh/ExpandingMan/Arrow.jl

@ExpandingMan
Copy link
Owner Author

ExpandingMan commented Mar 14, 2018

Yes, I've noticed that. I might actually consider getting rid of some of the constructors, there are probably too many of them, I feel like half of this package is constructors. The tests I've added so far were intended to make damn sure that this will never segfault (at least not because of Arrow, users can still cause it). Feather tests have also been very helpful with ensuring that. Fortunately 0.7 detects a large class of segfaults and throws a proper error for a large class of them at seemingly zero cost, so that's good.

Tests that we are currently missing that I am most concerned about are for writing.

@ExpandingMan
Copy link
Owner Author

Phew... ok I now have in a hell of a lot more unit tests. I haven't seen what the coverage is yet, but now pretty much all of the "important" stuff is being tested. Probably not going to do more myself for quite a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants