Skip to content

Listwise transformer unit tests are unintentionally order-independent #28

@jamesdshinner

Description

@jamesdshinner

The unit tests for listwise transformers are written in such a way that permutations in the order of the returned values will still pass the test

E.g. actual = [1, 2, 3], expected = [1, 3, 2] will still pass, when it should fail.

I don't think this is causing any broken functionality to pass unit tests as it stands, but we should tidy this up by changing to e.g. how tests are implemented for the new rank transformer in #26

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions