[HOLD for payment 2025-01-28] [Workspace Feeds] Adding additional custom feed overwrites the existing feed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): quality

Action Performed:

1. Set up a Visa feed
2. Add additional Visa feed with existing one

Expected Result:

2nd Visa card should be showing as pending

Actual Result:

Existing already added visa card is overwritten
NOTE : Issue not happening with different types of card feed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-11-04_16-00-46.2.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[mountiny]

I think we might need to pass updated name like vcf2

[m-natarajan]

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

[mountiny]

As discussed in slack here https://expensify.enterprise.slack.com/archives/C05LX9D6E07/p1730794651148409?thread_ts=1730755550.229969&channel=C05LX9D6E07&message_ts=1730794651.148409 right now we are intentionally overwriting the feed when we add a new one of the same type.

We will need to build this support into newDot. We can try to use the feedID locally and increment it and handle any errors due to existing feed with this feed id using the rbr

[mountiny]

Still to be handled

[melvin-bot]

@garrettmknight @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

not worked on yet

[mountiny]

Weekly

[mountiny]

This should for now be only for the custom feeds to match oldDot behaviour

[mountiny]

Havent got around

[garrettmknight]

Same as above

[garrettmknight]

Same as above

[mountiny]

Working on fire clean up and issues from real customers now but this is on the list

[mountiny]

This should be fixed with https://github.com/Expensify/App/pull/55223/files actually

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [InternalQA] fix: always send feedType with the order number for custom feeds #55223

If no regressions arise, payment will be issued on 2025-01-28. 🎊

[melvin-bot]

@mountiny @garrettmknight @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.