[Due for payment 2026-02-20] [$250] Filters - Something went wrong shown when applied Has filter in chats and changed to expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 iOS 26.1, MacBook Air Chrome
App Component: Search

Action Performed:

1. Sign in to ND
2. Go to Reports tab, select Chats on LHN
3. Click Has dropdown filter, select Link, apply - search query shows "type:chat has:link"
4. Click Type dropdown filter, select Expense, apply - search query shows "type:expense has:link", "Something went wrong" page appears

Expected Result:

"Something went wrong" page is not shown

Actual Result:

"Something went wrong" page is shown when applied filter in chats and changed type to expense. The search query shows type:expense has:link. The same issue happens, if apply Has filter for expense and change the type dropdown to chat

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7028373_1765589459079.Something_went_wrong_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022000784836527589969
• Upwork Job ID: 2000784836527589969
• Last Price Increase: 2026-01-13
• Automatic offers:
• daledah | Contributor | 110119946

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When switching search type (e.g., from Chat to Expense) with a Has filter applied, incompatible filter values persist in the query, creating invalid combinations like type:expense has:link.

What is the root cause of that problem?

The root cause is that when switching search type, the has filter values are not being properly filtered based on type-specific validity.

Type-Specific Has Values:

The has filter values are type-specific as defined in getHasOptions() function in SearchUIUtils.ts:

App/src/libs/SearchUIUtils.ts

Lines 2926 to 2943 in eb5789f

	function getHasOptions(translate: LocalizedTranslate, type: SearchDataTypes) {
	switch (type) {
	case CONST.SEARCH.DATA_TYPES.EXPENSE:
	return [
	{text: translate('common.receipt'), value: CONST.SEARCH.HAS_VALUES.RECEIPT},
	{text: translate('common.attachment'), value: CONST.SEARCH.HAS_VALUES.ATTACHMENT},
	{text: translate('common.tag'), value: CONST.SEARCH.HAS_VALUES.TAG},
	{text: translate('common.category'), value: CONST.SEARCH.HAS_VALUES.CATEGORY},
	];
	case CONST.SEARCH.DATA_TYPES.CHAT:
	return [
	{text: translate('common.link'), value: CONST.SEARCH.HAS_VALUES.LINK},
	{text: translate('common.attachment'), value: CONST.SEARCH.HAS_VALUES.ATTACHMENT},
	];
	default:
	return [];
	}
	}

• For type:chat: Only link and attachment are valid
• For type:expense: Only receipt, attachment, tag, category are valid
• Note: attachment is valid for both types

Filter Key vs Filter Value Validation:

The existing ALLOWED_TYPE_FILTERS in SearchAdvancedFiltersForm.ts only validates that the has filter key is allowed for both types, but it doesn't validate the values within the filter:

[CONST.SEARCH.DATA_TYPES.EXPENSE]: [
    // ...
    FILTER_KEYS.HAS,      // Key is allowed
    FILTER_KEYS.HAS_NOT,
],
[CONST.SEARCH.DATA_TYPES.CHAT]: [
    // ...
    FILTER_KEYS.HAS,      // Key is allowed
    FILTER_KEYS.HAS_NOT,
],

Missing Value Cleanup on Type Change:

When the type changes, only status and groupBy are reset, but has values are NOT filtered:

In SearchFiltersBar.tsx (updateFilterForm):

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 301 to 305 in eb5789f

	// If the type has changed, reset the status so we dont have an invalid status selected
	if (updatedFilterFormValues.type !== searchAdvancedFiltersForm.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	updatedFilterFormValues.columns = [];
	}

The code only resets status and columns, but doesn't clean up incompatible has values.

In SearchFiltersTypePage.tsx (applyChanges):

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

Lines 45 to 56 in eb5789f

	const applyChanges = useCallback(() => {
	const hasTypeChanged = selectedItem !== searchAdvancedFiltersForm?.type;
	const updatedFilters = {
	type: selectedItem,
	...(hasTypeChanged && {
	groupBy: null,
	status: CONST.SEARCH.STATUS.EXPENSE.ALL,
	}),
	};
	updateAdvancedFilters(updatedFilters);
	Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
	}, [searchAdvancedFiltersForm?.type, selectedItem]);

Similarly, only groupBy and status are reset when type changes, with no cleanup of incompatible has values.

Why the bug occurs:

1. User applies type:chat has:link filter
2. User changes type to Expense via dropdown
3. Code checks if has filter KEY is allowed for Expense type → Yes (it's in ALLOWED_TYPE_FILTERS)
4. Code does NOT check if link VALUE is valid for Expense type
5. Invalid query type:expense has:link is generated and displayed to the user
6. This creates a confusing UX where the query shows invalid filter combinations

What changes do you think we should make in order to solve the problem?

Filter out incompatible has values when the type changes using the getHasOptions() function. This requires changes in two files where type switching occurs.

---

Change 1: Update SearchFiltersBar.tsx

File: App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 294 to 334 in eb5789f

	const updateFilterForm = useCallback(
	(values: Partial<SearchAdvancedFiltersForm>) => {
	const updatedFilterFormValues: Partial<SearchAdvancedFiltersForm> = {
	...searchAdvancedFiltersForm,
	...values,
	};
	// If the type has changed, reset the status so we dont have an invalid status selected
	if (updatedFilterFormValues.type !== searchAdvancedFiltersForm.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	updatedFilterFormValues.columns = [];
	}
	if (updatedFilterFormValues.groupBy !== searchAdvancedFiltersForm.groupBy) {
	updatedFilterFormValues.columns = [];
	}
	const queryString = buildQueryStringFromFilterFormValues(updatedFilterFormValues);
	close(() => {
	// We want to explicitly clear stale rawQuery since it’s only used for manually typed-in queries.
	Navigation.setParams({q: queryString, rawQuery: undefined});
	});
	},
	[searchAdvancedFiltersForm],
	);
	const openAdvancedFilters = useCallback(() => {
	updateAdvancedFilters(filterFormValues);
	Navigation.navigate(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
	}, [filterFormValues]);
	const openSearchColumns = () => {
	Navigation.navigate(ROUTES.SEARCH_COLUMNS);
	};
	const typeComponent = useCallback(
	({closeOverlay}: PopoverComponentProps) => {
	return (
	<SingleSelectPopup
	label={translate('common.type')}

Update the updateFilterForm callback to filter incompatible has values when type changes:

const updateFilterForm = useCallback(
    (values: Partial<SearchAdvancedFiltersForm>) => {
        const updatedFilterFormValues: Partial<SearchAdvancedFiltersForm> = {
            ...searchAdvancedFiltersForm,
            ...values,
        };

        // If the type has changed, reset the status so we dont have an invalid status selected
        if (updatedFilterFormValues.type !== searchAdvancedFiltersForm.type) {
            updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
            updatedFilterFormValues.columns = [];

            // Filter out incompatible 'has' values for the new type
            const newType = updatedFilterFormValues.type ?? CONST.SEARCH.DATA_TYPES.EXPENSE;
            const validHasOptions = getHasOptions(translate, newType).map((option) => option.value);
            if (updatedFilterFormValues.has) {
                updatedFilterFormValues.has = updatedFilterFormValues.has.filter((hasValue) => 
                    validHasOptions.includes(hasValue)
                );
                // Clear has if no valid values remain
                if (updatedFilterFormValues.has.length === 0) {
                    updatedFilterFormValues.has = undefined;
                }
            }
            // Clear 'is' filter if switching away from chat type (is is chat-only)
            if (newType !== CONST.SEARCH.DATA_TYPES.CHAT && updatedFilterFormValues.is) {
                updatedFilterFormValues.is = undefined;
            }
        }

        if (updatedFilterFormValues.groupBy !== searchAdvancedFiltersForm.groupBy) {
            updatedFilterFormValues.columns = [];
        }

        const queryString = buildQueryStringFromFilterFormValues(updatedFilterFormValues);

        close(() => {
            Navigation.setParams({q: queryString, rawQuery: undefined});
        });
    },
    [searchAdvancedFiltersForm, translate],
);

Key changes:

• Add logic to filter has values using getHasOptions() to get valid options for the new type
• Clear has entirely if no valid values remain after filtering
• Also clear the chat-only is filter when switching away from chat type
• Add translate to the dependency array

---

Change 2: Update SearchFiltersTypePage.tsx

File: App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

Lines 1 to 12 in eb5789f

	import React, {useCallback, useMemo, useState} from 'react';
	import {View} from 'react-native';
	import FixedFooter from '@components/FixedFooter';
	import HeaderWithBackButton from '@components/HeaderWithBackButton';
	import ScreenWrapper from '@components/ScreenWrapper';
	import SearchFilterPageFooterButtons from '@components/Search/SearchFilterPageFooterButtons';
	import SelectionList from '@components/SelectionList';
	import SingleSelectListItem from '@components/SelectionList/ListItem/SingleSelectListItem';
	import type {ListItem} from '@components/SelectionList/types';
	import useLocalize from '@hooks/useLocalize';
	import useOnyx from '@hooks/useOnyx';
	import useThemeStyles from '@hooks/useThemeStyles';

Step 1: Update the import statement (line 15):

import {getHasOptions, getTypeOptions} from '@libs/SearchUIUtils';

Step 2: Update the applyChanges callback:

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

Lines 45 to 56 in eb5789f

	const applyChanges = useCallback(() => {
	const hasTypeChanged = selectedItem !== searchAdvancedFiltersForm?.type;
	const updatedFilters = {
	type: selectedItem,
	...(hasTypeChanged && {
	groupBy: null,
	status: CONST.SEARCH.STATUS.EXPENSE.ALL,
	}),
	};
	updateAdvancedFilters(updatedFilters);
	Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
	}, [searchAdvancedFiltersForm?.type, selectedItem]);

const applyChanges = useCallback(() => {
    const hasTypeChanged = selectedItem !== searchAdvancedFiltersForm?.type;

    // Calculate which 'has' values are valid for the new type
    let filteredHasValues: string[] | undefined;
    if (hasTypeChanged && searchAdvancedFiltersForm?.has) {
        const validHasOptions = getHasOptions(translate, selectedItem).map((option) => option.value);
        const validValues = searchAdvancedFiltersForm.has.filter((hasValue) => 
            validHasOptions.includes(hasValue)
        );
        filteredHasValues = validValues.length > 0 ? validValues : undefined;
    }

    const updatedFilters = {
        type: selectedItem,
        ...(hasTypeChanged && {
            groupBy: null,
            status: CONST.SEARCH.STATUS.EXPENSE.ALL,
            has: filteredHasValues,
            // Clear 'is' filter if not switching to chat type (is is chat-only)
            ...(selectedItem !== CONST.SEARCH.DATA_TYPES.CHAT && {is: undefined}),
        }),
    };
    updateAdvancedFilters(updatedFilters);
    Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
}, [searchAdvancedFiltersForm?.type, searchAdvancedFiltersForm?.has, selectedItem, translate]);

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-07 08:36:22 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When changing from type:chat to type:expense, has:link is not removed from the search query more info here

What is the root cause of that problem?

The has field in type expense doesn't have link option

App/src/libs/SearchUIUtils.ts

Lines 2924 to 2937 in 566a084

	function getHasOptions(translate: LocalizedTranslate, type: SearchDataTypes) {
	switch (type) {
	case CONST.SEARCH.DATA_TYPES.EXPENSE:
	return [
	{text: translate('common.receipt'), value: CONST.SEARCH.HAS_VALUES.RECEIPT},
	{text: translate('common.attachment'), value: CONST.SEARCH.HAS_VALUES.ATTACHMENT},
	{text: translate('common.tag'), value: CONST.SEARCH.HAS_VALUES.TAG},
	{text: translate('common.category'), value: CONST.SEARCH.HAS_VALUES.CATEGORY},
	];
	case CONST.SEARCH.DATA_TYPES.CHAT:
	return [
	{text: translate('common.link'), value: CONST.SEARCH.HAS_VALUES.LINK},
	{text: translate('common.attachment'), value: CONST.SEARCH.HAS_VALUES.ATTACHMENT},
	];

When switching from CHAT to EXPENSE with "has:link" applied, we are not deleting invalid has options for the new type.

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 310 to 319 in 8cd91dc

	if (updatedFilterFormValues.type !== filterFormValues.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	}
	const queryString = buildQueryStringFromFilterFormValues(updatedFilterFormValues);
	close(() => {
	// We want to explicitly clear stale rawQuery since it’s only used for manually typed-in queries.
	Navigation.setParams({q: queryString, rawQuery: undefined});
	});

What changes do you think we should make in order to solve the problem?

we should update updateFilterForm in SearchFiltersBar.tsx to filter out invalid "has" values when the type changes by

• Gets valid "has" options for the new type using getHasOptions
• Filters existing "has" values to only include those valid for the new type
• Clears the "has" filter if no valid values remain

      if (updatedFilterFormValues.type !== filterFormValues.type) {
          updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
          // Filter out invalid "has" values for the new type
          if (updatedFilterFormValues.has && updatedFilterFormValues.type) {
              const validHasOptions = getHasOptions(translate, updatedFilterFormValues.type);
              const validHasValues = new Set(validHasOptions.map((option) => option.value));
              const filteredHasValues = updatedFilterFormValues.has.filter((hasValue) => validHasValues.has(hasValue as ValueOf<typeof CONST.SEARCH.HAS_VALUES>));
              updatedFilterFormValues.has = filteredHasValues.length > 0 ? filteredHasValues : undefined;
          }
      }

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 310 to 319 in 8cd91dc

	if (updatedFilterFormValues.type !== filterFormValues.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	}
	const queryString = buildQueryStringFromFilterFormValues(updatedFilterFormValues);
	close(() => {
	// We want to explicitly clear stale rawQuery since it’s only used for manually typed-in queries.
	Navigation.setParams({q: queryString, rawQuery: undefined});
	});

then we should update the applyChanges in SearchFiltersTypePage component to

    const applyChanges = useCallback(() => {
        const hasTypeChanged = selectedItem !== searchAdvancedFiltersForm?.type;
        const validHasOptions = getHasOptions(translate, selectedItem);
        const validHasValues = new Set(validHasOptions.map((option) => option.value));
        const filteredHasValues = searchAdvancedFiltersForm?.has?.filter((hasValue) => validHasValues.has(hasValue as ValueOf<typeof CONST.SEARCH.HAS_VALUES>));
        const updatedFilters = {
            type: selectedItem,
            ...(hasTypeChanged && {
                groupBy: null,
                status: CONST.SEARCH.STATUS.EXPENSE.ALL,
                has: filteredHasValues,
            }),
        };
        updateAdvancedFilters(updatedFilters);
        Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
    }, [searchAdvancedFiltersForm?.has, searchAdvancedFiltersForm?.type, selectedItem, translate]);

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx

Lines 45 to 56 in eb5789f

	const applyChanges = useCallback(() => {
	const hasTypeChanged = selectedItem !== searchAdvancedFiltersForm?.type;
	const updatedFilters = {
	type: selectedItem,
	...(hasTypeChanged && {
	groupBy: null,
	status: CONST.SEARCH.STATUS.EXPENSE.ALL,
	}),
	};
	updateAdvancedFilters(updatedFilters);
	Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute());
	}, [searchAdvancedFiltersForm?.type, selectedItem]);

Note: we should do the same for other filter options if its have the same problem

Result:

Screen.Recording.2025-12-14.at.01.55.03.mov

What alternative solutions did you explore? (Optional)

Or we can simply update the updatedFilterFormValues.has to undefined if the type is changed

            if (updatedFilterFormValues.type !== filterFormValues.type) {
                updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
                updatedFilterFormValues.has = undefined;
            }

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Filters - Something went wrong shown when applied Has filter in chats and changed to expense

What is the root cause of that problem?

When switching between search types, the code was always setting status = CONST.SEARCH.STATUS.EXPENSE.ALL, even when switching to the CHAT type. However, CHAT type doesn't support the status filter at all (as defined in ALLOWED_TYPE_FILTERS). This caused the query builder to generate an invalid query string with a status filter for CHAT type, which is not supported

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 309 to 314 in 92dec2d

	// If the type has changed, reset the status so we dont have an invalid status selected
	if (updatedFilterFormValues.type !== filterFormValues.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	}
	const queryString = buildQueryStringFromFilterFormValues(updatedFilterFormValues);

What changes do you think we should make in order to solve the problem?

We only set status for types that support it (CHAT doesn't have status)

            // If the type has changed, reset the status so we dont have an invalid status selected
            if (updatedFilterFormValues.type !== filterFormValues.type) {
                const newType = updatedFilterFormValues.type ?? CONST.SEARCH.DATA_TYPES.EXPENSE;
                if (newType === CONST.SEARCH.DATA_TYPES.CHAT) {
                    updatedFilterFormValues.status = undefined;
                } else {
                    updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
                }
            }

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 309 to 312 in 92dec2d

	// If the type has changed, reset the status so we dont have an invalid status selected
	if (updatedFilterFormValues.type !== filterFormValues.type) {
	updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
	}

What alternative solutions did you explore? (Optional)

            if (updatedFilterFormValues.type !== filterFormValues.type) {
                const newType = updatedFilterFormValues.type ?? CONST.SEARCH.DATA_TYPES.EXPENSE;
                // Only set status for types that support it (e.g., CHAT doesn't have status)
                if (isFilterSupported(FILTER_KEYS.STATUS, newType)) {
                    updatedFilterFormValues.status = CONST.SEARCH.STATUS.EXPENSE.ALL;
                } else {
                    updatedFilterFormValues.status = undefined;
                }
            }

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[tsa321]

I think this is a BE error. You can reproduce the issue by directly editing the text in the text box:

test_d.mp4

[RachCHopkins]

I can't repro on iOS v 9.2.78-2 or Android v9.2.75-0. Requesting retest.

[daledah]

@RachCHopkins It seems the "Something went wrong" page bug has been fixed. However, there's still one more issue: when changing from type:chat to type:expense, has:link is not removed from the search query (because the has field in type expense doesn't have link option). We should remove the has:link query in the same way we do with is:. Please see this video:

Screen.Recording.2025-12-16.at.11.17.53.mov

[RachCHopkins]

Cool, thank makes sense, thanks @daledah !

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022000784836527589969