Reports - Dates are still applied after being resetted on "Custom Range" filter.

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.52-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85313
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Search

Action Performed:

1. Open the Expensify app.
2. Navigate to "Reports" > "Expenses"
3. Tap on "Filters"
4. Scroll down to "Date" filter and open it.
5. Tap on "Custom Range"
6. Select any date on each calendar and save.
7. Note that now, selected dates are visible on "Date" field after landing on "Filters" page.
8. Reopen date filter and reopen "Custom Range"
9. Tap on "Reset"
10. Note that you land on "Date" page and reset dates are still visible on "Custom Range" field.
11. Tap on "Reset" again,
12. Note that now, dates disappear.

Expected Result:

Selected dates should disappear from "Custom Range" field after being reset on calendars page.

Actual Result:

Selected dates are still displayed on "Custom Range" field after being reset from calendars page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85313

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

DateFilterBase.reset() (src/components/Search/FilterComponents/DateFilterBase.tsx:152-167) clears the date values in local component state but never calls onSubmit() to persist the cleared values back to Onyx. A sync effect in DatePresetFilterBase.tsx:180-199 then detects that local state differs from the (unchanged) Onyx-backed defaultDateValues and restores the stale values, overwriting the reset.

This is why it takes two resets — the first reset clears local state, the sync effect restores stale Onyx values, and the second reset clears again from this now-slightly-different state.

The popup variant (DateSelectPopup/index.tsx:115-134) does not have this bug because its resetChanges correctly calls onChange(dateValues) after clearing, which propagates cleared values to the parent/Onyx.

What changes do you think we should make in order to solve the problem?

In DateFilterBase.reset(), after clearing the date values, call onSubmit with the cleared values so they are persisted to Onyx — matching what DateSelectPopup.resetChanges already does with onChange.

Specifically, in the selectedDateModifier branch, after clearDateValueOfSelectedDateModifier(), get the updated date values and pass them to onSubmit. In the fallback branch, after clearDateValues(), do the same. This ensures Onyx is updated immediately on reset, preventing the sync effect from restoring stale data.

What alternative solutions did you explore? (Optional)

An alternative would be to modify the sync effect in DatePresetFilterBase to not overwrite local state when a reset is in progress (e.g., via a ref flag). However, persisting the cleared values to Onyx is simpler, more consistent with the popup variant's behavior, and ensures the source of truth is always correct.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.