QBD - The self workspace with a connection error is still listed as reusable

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.55-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176907/test-cases/41237427
Email or phone of affected tester (no customers): applausetester+ag.qbd@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11/ Chrome
App Component: Workspace Settings

Action Performed:

Preconditions: Have a workspace with the Accounting feature enabled with the next error connection: Can't connect to QuickBooks Desktop ("Data sync did not complete, please make sure the Web Connector is running and try again later.")
Steps to reach this condition:

1. Go to workspace settings > Accounting
2. Click Connect, next to QuickBooks Desktop
3. Click Done

Steps:

1. Navigate to https://staging.new.expensify.com/
2. Log in as a workspace admin
3. Go to workspace settings > Accounting
4. Click on the three dots button > Reinstall connector

Expected Result:

Below the Existing connections section, workspaces with a connection error should not appear as reusable. Also, only other workspaces should be available, not the self workspace.

Actual Result:

The self workspace that shows a connection error is available for reuse.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86909 - "Reuse existing QBD connection across workspaces" by @lakchote (High confidence)
Related Issues: #86674 (original issue this PR fixed)

Recommendation: REVERT

PR 86909 introduced the QBD existing-connections reuse feature with two bugs in the selector/filtering logic: it includes the current workspace (self workspace) in the reusable list, and it includes workspaces that have connection errors. Both omissions are in the newly introduced adminPoliciesConnectedToQBDSelector and QuickbooksDesktopExistingConnectionsPage.

Assigned: @lakchote (PR author), @ahmedGaber93 (approving reviewer), @francoisl (approving reviewer)
Labels: DeployBlockerCash kept (frontend App PR caused the issue). No label changes made.

Detailed Analysis

Evidence

• The bug is staging-only and marked as "new feature, doesn't exist in prod", confirming it was introduced in this staging cycle.
• PR 86909 was merged 2026-04-08 and is part of the current StagingDeployCash (v9.3.55-0).
• The PR introduces QuickbooksDesktopExistingConnectionsPage and adminPoliciesConnectedToQBDSelector, which are the exact components involved in the reported bug.
• The "Reinstall connector" three-dots menu item in PolicyAccountingPage.tsx (line 137) calls startIntegrationFlow({name: QBD}), which routes through ConnectToQuickbooksDesktopFlow. That component navigates to QuickbooksDesktopExistingConnectionsPage whenever hasPoliciesConnectedToQBD is true.

Verification

• Affected file: src/pages/workspace/accounting/qbd/QuickbooksDesktopExistingConnectionsPage.tsx - created by PR 86909
• Affected file: src/selectors/Policy.ts - adminPoliciesConnectedToQBDSelector added by PR 86909
• Affected file: src/hooks/useAdminPoliciesConnectedToQBD.ts - created by PR 86909

All three files were introduced or modified by PR 86909. The PR directly modifies the code paths responsible for the reported behavior.

Root Cause

The adminPoliciesConnectedToQBDSelector in src/selectors/Policy.ts (line 136-137) filters policies only by admin role and presence of a QBD connection object. It is missing two conditions:

1. It does not exclude the policy whose policyID matches the one currently being configured (self workspace). The policyID is available in QuickbooksDesktopExistingConnectionsPage from route params but is not passed to the selector.
2. It does not exclude policies whose QBD connection has a sync error (checking policy.connections.quickbooksDesktop.lastSync?.errorMessage or equivalent).

The "Reinstall connector" menu item is only shown when shouldShowSynchronizationError is true for a QBD workspace — meaning the user is guaranteed to be on a workspace that has a QBD error, and that workspace will always appear in the reuse list since the selector does not filter by connection health.