"Pay" appears offline for bulk selected expenses in report

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.58-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85796 Test 9, step 5
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: MacBook Air 15.7.4 Chrome, iPhone 15 iOS 26.3.1
App Component: Money Requests

Action Performed:

1. Sign in to ND
2. Create a workspace, create a report with 2-3 expenses
3. Go offline
4. Open an expense report, long-press to enter selection mode, select all expenses
5. Click Submit, select all the expenses again and click Approve
6. Select all the expenses and verify Pay does not appear

Expected Result:

"Pay" does not appear for bulk selected expenses in offline mode

Actual Result:

"Pay" appears for bulk selected expenses in offline mode

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7126906_1775837845288.Pay_appears_offline.MP4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #85796

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[roryabraham]

Where do the expected steps come from? Is there some reason bulk-paying expense reports is not expected to be supported offline?

[OSBotify]

Investigation Summary - Classification: Frontend bug. Causing PR: #85796 by @Krishna2323 (High confidence). Title: Add selection mode Submit/Approve/Pay actions for mobile layout. Recommendation: REVERT. PR 85796 introduced selection mode Submit/Approve/Pay actions for mobile layout and contains a logic error causing Pay to appear while offline. Reverting will immediately fix the issue since this is a new feature not yet in production. Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @puneetlath (approving reviewer). Labels: DeployBlockerCash is correctly applied - no label changes needed. Root cause: The bug is in src/hooks/useSelectionModeReportActions.ts at line 509. The offline guard is: hasPayAction AND NOT (isOffline AND NOT canAllowSettlement). This only hides Pay when BOTH isOffline is true AND canAllowSettlement is false. Since canAllowSettlement is computed from hasUpdatedTotal(report, policy) and can return true even while offline (it checks if the report total is up to date, not network connectivity), Pay renders in offline mode whenever the report has a valid total. The expected behavior per QA step 9 of the PR itself is that Pay should not appear when offline. The fix should use a direct isOffline check to unconditionally hide Pay when offline.