[No QA] Helpsite updates for bulk edit expenses #88247
[No QA] Helpsite updates for bulk edit expenses #88247stephanieelliott wants to merge 6 commits intomainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| title: Edit Expenses | ||
| description: Learn how to edit individual expenses, and edit multiple expenses at once. | ||
| keywords: [bulk edit expenses, edit multiple expenses Expensify, update expenses in bulk, modify multiple expenses] | ||
| internalScope: Audience is all members. Covers editing expenses individually and in bulk bulk editing multiple expenses at once. Does not cover creating, submitting or reopening reports. |
There was a problem hiding this comment.
Typo in internalScope: There is a duplicate phrase -- "in bulk bulk editing multiple expenses at once" should be "in bulk, and editing multiple expenses at once" or similar. The repeated "bulk" reads as a copy-paste error.
| - **Current approver**: Can edit expenses on Outstanding reports pending their approval. | ||
| - **Workspace Admin**: Can edit expenses on any Draft or Outstanding report on the Workspace. | ||
|
|
||
| Expenses on Approved reports must be unapproved before they can be edited. Expenses on Paid and Done report cannot be edited. |
There was a problem hiding this comment.
Grammar: "Done report" should be "Done reports" (plural) to match the pattern of the rest of the sentence ("Paid and Done reports cannot be edited").
Update redirects.csv
| - Date | ||
| - Other fields like Category, Tag and Attendees | ||
|
|
||
| **Note:** Expenses on Approved reports must be unapproved before they can be edited. Expenses on Paid or Done reports cannot be edited. [Learn how to unapprove a report](Approve expenses](/articles/new-expensify/reports-and-expenses/Approve-Expenses). |
There was a problem hiding this comment.
Broken markdown link: The link syntax is malformed -- it reads [Learn how to unapprove a report](Approve expenses](/articles/...). There is a missing opening bracket and extra text. It should be:
| **Note:** Expenses on Approved reports must be unapproved before they can be edited. Expenses on Paid or Done reports cannot be edited. [Learn how to unapprove a report](Approve expenses](/articles/new-expensify/reports-and-expenses/Approve-Expenses). | |
| **Note:** Expenses on Approved reports must be unapproved before they can be edited. Expenses on Paid or Done reports cannot be edited. [Learn how to unapprove a report](/articles/new-expensify/reports-and-expenses/Approve-Expenses). |
|
|
||
| No, Paid or Done reports are locked and cannot be reopened for editing. | ||
|
|
||
| ## Why are some fields not editable in the Edit multiple panel? |
There was a problem hiding this comment.
Typo: "iit" should be "it".
| ## Why are some fields not editable in the Edit multiple panel? | |
| If a field is restricted for any selected expense (for example, amount on a card expense), it will be disabled in the **Edit multiple** panel. |
|
|
||
| If a field is restricted for any selected expense (for example, amount on a card expense), iit will be disabled in the **Edit multiple** panel. | ||
|
|
||
| ## Why can't I see the Edit multiple option? |
There was a problem hiding this comment.
Typo: "our" should be "or" -- "Unreported, Draft, or Outstanding expenses".
| ## Why can't I see the Edit multiple option? | |
| **Edit multiple** only appears when you select 2 or more Unreported, Draft, or Outstanding expenses that have at least one editable field. |
| 3. Open the Outstanding or Done report you want to retract. | ||
| 4. Choose **More**. | ||
| 5. Select **Retract**. | ||
|
|
There was a problem hiding this comment.
Three Dots Menu Rule violation (HELPSITE_NAMING_CONVENTIONS.md): "Choose More" is prohibited. The governance rules explicitly state: do not call it "More" and do not write "More menu." You must use: "Select the three dots (⋮)."
| 4. Select the three dots **(⋮)**. |
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile) go to **Spend > Reports**. | ||
| 3. Open the Outstanding or Done report you want to retract. | ||
| 4. Choose **More**. |
There was a problem hiding this comment.
Step numbering error: Steps jump from 1 to 3 -- step 2 is missing. This appears to be a numbering typo. The sequence should be 1, 2, 3, 4.
| ## What happens after you retract a report | ||
|
|
||
| - The report status will change to Draft. | ||
| - A Retracted message appears in the report activity. |
There was a problem hiding this comment.
Inconsistent list indentation: The bullet list has inconsistent leading spaces -- lines 38 and 40 have a leading space before the dash while lines 39 and 41 do not. This can cause unexpected rendering. All bullets should start at column 0 with no leading space.
| - A Retracted message appears in the report activity. | |
| - The report status will change to Draft. |
| - The report status will change to Draft. | ||
| - A Retracted message appears in the report activity. | ||
| - You can update, add, remove, or move expenses. | ||
| - You can resubmit the report when ready. |
There was a problem hiding this comment.
Inconsistent list indentation: Same leading-space issue as line 38. Remove the extra space before the dash.
| - You can resubmit the report when ready. | |
| - You can update, add, remove, or move expenses. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
bot
requested review from
stitesExpensify and
strepanier03
and removed request for
a team
|
@stitesExpensify @strepanier03 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
stephanieelliott
requested review from
heyjennahay
and removed request for
stitesExpensify and
strepanier03
HelpDot Documentation ReviewOverall AssessmentThis PR splits Scores Summary
Key FindingsMust fix before merge:
Should fix:
Positive aspects:
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
github-actions
bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://c5d63010.helpdot.pages.dev ⚡️ Updated articles: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53a50d3ee8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - **All members**: Can retract their own Outstanding and Done reports. | ||
| - **Current approver**: Can retract Outstanding reports pending their approval. | ||
| - **Workspace Admin**: Can retract any Outstanding or Done report on the Workspace. |
There was a problem hiding this comment.
This section overstates who can retract reports: the app only allows Retract when the current user is the submitter and the report is in processing (isRetractAction), while closed/Done reports are gated by admin-only isReopenAction (src/libs/ReportSecondaryActionUtils.ts:631-670). Documenting that all members can retract Done reports, and that approvers can retract Outstanding reports, will lead users to a workflow they cannot perform.
Useful? React with 👍 / 👎.
| - Date | ||
| - Other fields like Category, Tag and Attendees | ||
|
|
||
| **Note:** Expenses on Approved reports must be unapproved before they can be edited. Expenses on Paid or Done reports cannot be edited. [Learn how to unapprove a report](Approve expenses](/articles/new-expensify/reports-and-expenses/Approve-Expenses). |
There was a problem hiding this comment.
The unapprove reference is malformed ([Learn how to unapprove a report](Approve expenses](/articles/...) so the link will not render correctly and users cannot navigate to the required prerequisite flow from this page.
Useful? React with 👍 / 👎.
| --- | ||
| title: Edit Reports | ||
| description: Retract a submitted expense report to make changes, update expenses, and resubmit. | ||
| keywords: [New Expensify, edit expense report, retract report, update submitted report, resubmit expense report, exported report changes] | ||
| internalScope: Audience is Members and Workspace Admins. Covers retracting and updating submitted expense reports. Does not cover creating reports or detailed expense editing workflows. |
There was a problem hiding this comment.
This change replaces Edit-Expense-Reports with Edit-Reports but does not define a redirect, while other docs still link to the old URL (for example docs/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses.md:41). Without redirect_from on the new page, existing internal/external links to the old slug will break.
Useful? React with 👍 / 👎.
2 participants
Fixes $ https://github.com/Expensify/Expensify/issues/620451
Master project issue: https://github.com/Expensify/Expensify/issues/541817
Description: