[Payment due @ZhenjaHorbach] [Personal Karma] Add NewDot toggle flow under Save The World by fedirjh · Pull Request #84504 · Expensify/App

fedirjh · 2026-03-08T03:32:46Z

Explanation of Change

This PR adds Personal Karma support to NewDot under /settings/teachersunite.

Adds a Personal Karma toggle card in Save The World settings.
Connects the toggle to the new UpdatePersonalKarma API action.
Shows a confirmation modal when disabling donations.
Prompts for adding a payment card when enabling without a billing card, and reverts toggle state if the modal is dismissed.
Shows the billing card details when Personal Karma is enabled.
Moves Personal Karma text to translations and adds localized strings across all app languages.
Adds reusable subtitle-with-link rendering (SectionSubtitleHTML) and reusable billing card rendering (BillingCardDetails) used by related settings sections.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/601130
PROPOSAL:

Tests

Open /settings/teachersunite.
Verify the Personal Karma card is shown with the Personal Karma title and description text:
Donate $1 to Expensify.org for every $500 you spend each month Learn more.
Toggle Personal Karma on with a payment card present.
Verify the toggle is enabled and the billing card details are shown.
Toggle Personal Karma off.
Verify the stop-donations confirmation modal appears.
Tap cancel and verify Personal Karma stays enabled.
Toggle off again and confirm disable.
Verify Personal Karma is disabled.
Enable again on an account without a billing card.
Verify add-payment-card modal appears.
Dismiss the modal without adding a card and verify the toggle reverts to disabled.

Verify that no errors appear in the JS console

Offline tests

Go offline and open /settings/teachersunite.
Toggle Personal Karma on and off.
Verify there is no crash and the UI remains stable.
Reconnect and verify the latest state is synchronized.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

CleanShot.2026-03-12.at.00.36.48.mp4

CleanShot.2026-03-12.at.01.35.39.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

- Introduced ONYXKEYS for managing Personal Karma donation states. - Added new API command and parameters for updating Personal Karma. - Updated Subscription actions to include a function for updating Personal Karma. - Added a help URL for Personal and Corporate Karma in the constants.

- Created a new BillingCardDetails component to encapsulate billing card information display. - Replaced inline billing card rendering in CardSection with the new BillingCardDetails component for improved code organization and readability. - Removed unused imports and optimized existing code in CardSection.

- Added new translations for the Personal Karma feature in German, English, Spanish, French, Italian, Japanese, Dutch, Polish, Brazilian Portuguese, and Simplified Chinese. - Each translation includes title, description, prompts for adding a payment card, stopping donations, and the title for the donation card.

- Introduced a new SectionSubtitleHTML component to handle HTML subtitles with optional muted styling and link press handling. - Replaced instances of RenderHTML in various pages (DomainSamlPage, SecuritySettingsPage, TroubleshootPage, WorkspaceReportsPage, IndividualExpenseRulesSection) with SectionSubtitleHTML for improved consistency and maintainability. - Updated related styles and props to accommodate the new component.

- Integrated Personal Karma toggle functionality with modals for adding payment cards and disabling donations. - Added new state management for displaying billing card details and handling user interactions. - Updated UI components to include SectionSubtitleHTML for improved subtitle rendering. - Enhanced user experience with confirmation modals for payment card actions and personal karma updates.

melvin-bot · 2026-03-08T03:32:51Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-03-08T03:49:43Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.65% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/ROUTES.ts	`15.90% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...c/pages/workspace/reports/WorkspaceReportsPage.tsx	`0.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.87% <0.00%> (-0.01%)`	⬇️
...c/pages/settings/Security/SecuritySettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 9 more
... and 6 files with indirect coverage changes

src/components/PaymentCardDetails.tsx

src/CONST/index.ts

flodnv · 2026-03-09T15:49:00Z

@garrettmknight do you want to review the product side of this PR?

…dPage and CardSection - Introduced a new PaymentCardDetails component for displaying billing card information. - Replaced instances of BillingCardDetails with PaymentCardDetails in SaveTheWorldPage and CardSection for consistency and improved functionality.

flodnv · 2026-03-10T16:03:50Z

@fedirjh checks failed

trjExpensify

Overall, looking pretty good! Just a few things:

The toggle label supplied in the mocks from @dannymcclain read Enable Personal Karma. The video in the OP is slightly different.

The video only shows one case (you have a card already). Can you show the other case where you have to add a payment card so the evidence matches the tests to sense check?
Where did this copy change in the modal come from? Looks different to the mocks supplied in the parent issue.

Parent issue:

PR:

fedirjh · 2026-03-11T19:09:55Z

3. Where did this copy change in the modal come from?

we have this copy in OldDot. Will update it to match the OP

…ature - Introduced SETTINGS_SAVE_THE_WORLD_ADD_PAYMENT_CARD route in ROUTES.ts. - Added ADD_PAYMENT_CARD screen to SCREENS.ts. - Updated TeachersUniteNavigator to include the new ADD_PAYMENT_CARD screen. - Modified linking configuration to route to the new screen. - Adjusted SaveTheWorldPage to navigate to the new payment card screen and removed the old modal implementation.

fedirjh · 2026-03-12T00:38:24Z

@MelvinBot Fix prettier and lint errors?

Co-authored-by: Fedi Rajhi <[email protected]>

MelvinBot · 2026-03-12T00:41:05Z

Fixed the prettier and ESLint errors:

Prettier: Reordered imports alphabetically in PaymentCardDetails.tsx, SaveTheWorldPage.tsx, CardSection.tsx, and IndividualExpenseRulesSection.tsx
ESLint (prefer-early-return): Refactored the useEffect in SaveTheWorldPage.tsx to use an early return instead of wrapping the body in a conditional

trjExpensify · 2026-03-13T13:43:30Z

Should this be out of WIP now?

flodnv · 2026-04-07T14:43:04Z

Thanks @ZhenjaHorbach , please let me know when this is ready

ZhenjaHorbach · 2026-04-07T14:44:13Z

Thanks @ZhenjaHorbach , please let me know when this is ready

I think I will complete the review tomorrow morning!

flodnv · 2026-04-07T15:14:33Z

Thank you!

…

On Tue, Apr 7, 2026 at 10:44 AM Yauheni Horbach ***@***.***> wrote: *ZhenjaHorbach* left a comment (Expensify/App#84504) <#84504 (comment)> Thanks @ZhenjaHorbach <https://github.com/ZhenjaHorbach> , please let me know when this is ready I think I will complete the review tomorrow morning! — Reply to this email directly, view it on GitHub <#84504 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7Y2OPRJVEMHPRQCOJKO3L4UUH5JAVCNFSM6AAAAACWKXCKNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOJZHAZTOOJUGA> . You are receiving this because your review was requested.Message ID: ***@***.***>

ZhenjaHorbach · 2026-04-08T14:46:58Z

Minor comment
But should we add a pending action for Karma toggle?

2026-04-08.16.46.06.mov

As we usually do

2026-04-08.16.46.43.mov

ZhenjaHorbach · 2026-04-08T14:48:14Z

And should we have a dynamic price depending on location?
Or we will always have 1$?

src/pages/TeachersUnite/SaveTheWorldPage.tsx

ZhenjaHorbach · 2026-04-08T15:03:57Z

Minor comment
But we can directly navigate to settings/teachersunite/add-payment-card
Even when we already have a card
I suppose it's better to show Not here page

…AddPaymentCard component

fedirjh · 2026-04-08T18:10:36Z

And should we have a dynamic price depending on location? Or we will always have 1$?

IT should match the oldDot behaviour which was 1$ regardless of the location.

trjExpensify

Looks like my earlier review comments were addressed. 👍

flodnv · 2026-04-09T15:02:22Z

@ZhenjaHorbach could we please get a final review? 🙏

ZhenjaHorbach · 2026-04-09T15:03:51Z

I will recheck soon!

ZhenjaHorbach · 2026-04-09T15:18:46Z

Not sure that we need to disable the toggle when we have a pending action
But we can leave it as it is

2026-04-09.17.17.43.mov

ZhenjaHorbach · 2026-04-09T15:35:30Z

Not sure that we need to disable the toggle when we have a pending action But we can leave it as it is

2026-04-09.17.17.43.mov

But I will approve
Not sure if it's a critical issue

melvin-bot · 2026-04-09T15:35:50Z

🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/601130.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

flodnv · 2026-04-09T15:58:51Z

Thank you!

github-actions · 2026-04-09T15:59:50Z

🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-09T16:04:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84504.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-643d371-b0990c7-6d19a789025720ce9b279fd461cca7e90674add1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-643d371-b0990c7-7769e75afc832ceb494d147f4334bb187b08273c/index.html

Web 🕸️
https://84504.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-10T08:24:49Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.58-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-10T08:29:46Z

🤖 I reviewed the changes in this PR against the help site article at docs/articles/new-expensify/settings/Personal-Karma.md.

Changes are required. I've created a PR with the following updates:

Toggle label: Updated from "Personal Karma" to Enable Personal Karma to match the exact UI text
Disable flow: Added a separate section documenting the confirmation modal shown when disabling donations
Payment card requirement: Documented that a billing card is required to enable Personal Karma, and that dismissing the payment card prompt reverts the toggle
Billing card display: Documented that card details are shown below the toggle when enabled

Help site PR: #87571

fedirjh added 8 commits March 8, 2026 00:56

Remove donation card title from translations in multiple languages

30c7058

Refactor imports and enhance style

824cf87

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

2da801f

melvin-bot bot assigned fedirjh Mar 8, 2026

Enhance BillingCardDetails component and update translations

60c8b69

fedirjh requested a review from flodnv March 8, 2026 04:09

flodnv reviewed Mar 9, 2026

View reviewed changes

src/components/PaymentCardDetails.tsx Show resolved Hide resolved

src/CONST/index.ts Show resolved Hide resolved

fedirjh added 2 commits March 10, 2026 01:39

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

cb1acb3

trjExpensify self-requested a review March 10, 2026 16:15

trjExpensify requested changes Mar 10, 2026

View reviewed changes

fedirjh added 3 commits March 11, 2026 23:39

Update personal karma copy

e4dc325

Merge remote-tracking branch 'upstream' into personal-karma-new-dot

260ae39

fedirjh assigned MelvinBot Mar 12, 2026

Fix prettier formatting and ESLint prefer-early-return error

d61d13a

Co-authored-by: Fedi Rajhi <[email protected]>

fedirjh requested a review from trjExpensify March 12, 2026 00:52

ZhenjaHorbach reviewed Apr 8, 2026

View reviewed changes

src/pages/TeachersUnite/SaveTheWorldPage.tsx Outdated Show resolved Hide resolved

fedirjh added 3 commits April 8, 2026 18:39

feat: Add optimistic UI state for personal karma updates

be8f82d

feat: Integrate FullPageNotFoundView for enhanced user experience in …

61d7ea8

…AddPaymentCard component

Merge branch 'Expensify:main' into personal-karma-new-dot

dc3adc8

fedirjh requested a review from ZhenjaHorbach April 8, 2026 18:09

trjExpensify removed the request for review from heyjennahay April 9, 2026 13:49

trjExpensify approved these changes Apr 9, 2026

View reviewed changes

ZhenjaHorbach approved these changes Apr 9, 2026

View reviewed changes

melvin-bot bot changed the title ~~[Personal Karma] Add NewDot toggle flow under Save The World~~ [Payment due @ZhenjaHorbach] [Personal Karma] Add NewDot toggle flow under Save The World Apr 9, 2026

flodnv merged commit 643d371 into Expensify:main Apr 9, 2026
34 of 35 checks passed

fedirjh deleted the personal-karma-new-dot branch April 9, 2026 17:46

OSBotify mentioned this pull request Apr 10, 2026

Deploy Checklist: New Expensify 2026-04-10 #87562

Open

87 tasks

MelvinBot mentioned this pull request Apr 10, 2026

Update Personal Karma help article for NewDot toggle flow #87571

Open

3 tasks

Conversation

fedirjh commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 8, 2026

Uh oh!

codecov bot commented Mar 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

flodnv commented Mar 9, 2026

Uh oh!

flodnv commented Mar 10, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Mar 11, 2026

Uh oh!

fedirjh commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Mar 12, 2026

Uh oh!

trjExpensify commented Mar 13, 2026

Uh oh!

flodnv commented Apr 7, 2026

Uh oh!

ZhenjaHorbach commented Apr 7, 2026

Uh oh!

flodnv commented Apr 7, 2026 via email

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 8, 2026

Uh oh!

fedirjh commented Apr 8, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

flodnv commented Apr 9, 2026

Uh oh!

ZhenjaHorbach commented Apr 9, 2026

Uh oh!

ZhenjaHorbach commented Apr 9, 2026

Uh oh!

ZhenjaHorbach commented Apr 9, 2026

Uh oh!

melvin-bot bot commented Apr 9, 2026

Uh oh!

flodnv commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 10, 2026

Uh oh!

MelvinBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

fedirjh commented Mar 8, 2026 •

edited

Loading

codecov bot commented Mar 8, 2026 •

edited by github-actions bot

Loading

fedirjh commented Mar 12, 2026 •

edited

Loading