From 930a49c814a480144e1c429044a4561db1c976cb Mon Sep 17 00:00:00 2001 From: "Fitsum Abebe (via MelvinBot)" Date: Thu, 12 Mar 2026 15:35:09 +0000 Subject: [PATCH 1/2] Add accessibilityLabel to picker dismiss button Pass accessibilityLabel with 'Dismiss' copy via touchableDoneProps in BasePicker so the iOS picker dismiss button is announced by VoiceOver. Co-authored-by: Fitsum Abebe --- src/components/Picker/BasePicker.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/Picker/BasePicker.tsx b/src/components/Picker/BasePicker.tsx index 14413b126b7e4..031600231dbf9 100644 --- a/src/components/Picker/BasePicker.tsx +++ b/src/components/Picker/BasePicker.tsx @@ -10,6 +10,7 @@ import Icon from '@components/Icon'; import Text from '@components/Text'; import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useScrollContext from '@hooks/useScrollContext'; +import useLocalize from '@hooks/useLocalize'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import {isMobile} from '@libs/Browser'; @@ -42,6 +43,7 @@ function BasePicker({ ref, }: BasePickerProps) { const icons = useMemoizedLazyExpensifyIcons(['DownArrow']); + const {translate} = useLocalize(); const theme = useTheme(); const styles = useThemeStyles(); @@ -213,6 +215,7 @@ function BasePicker({ }} touchableDoneProps={{ accessibilityRole: CONST.ROLE.BUTTON, + accessibilityLabel: translate('common.dismiss'), }} touchableWrapperProps={{ accessible: true, From ebbc54de0ddeba733b796ef86da1be11255c69fa Mon Sep 17 00:00:00 2001 From: "Fitsum Abebe (via MelvinBot)" Date: Thu, 12 Mar 2026 15:39:32 +0000 Subject: [PATCH 2/2] Fix: sort imports alphabetically to pass Prettier check Co-authored-by: Fitsum Abebe --- src/components/Picker/BasePicker.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Picker/BasePicker.tsx b/src/components/Picker/BasePicker.tsx index 031600231dbf9..42c4cc56d45a2 100644 --- a/src/components/Picker/BasePicker.tsx +++ b/src/components/Picker/BasePicker.tsx @@ -9,8 +9,8 @@ import FormHelpMessage from '@components/FormHelpMessage'; import Icon from '@components/Icon'; import Text from '@components/Text'; import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; -import useScrollContext from '@hooks/useScrollContext'; import useLocalize from '@hooks/useLocalize'; +import useScrollContext from '@hooks/useScrollContext'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import {isMobile} from '@libs/Browser';