Skip to content

Commit c980bbd

Browse files
author
Hrvoje Vucic
committed
Merge branch 'release/5.0' into feature/display-published-status-in-progress-page
2 parents e53d815 + ec44152 commit c980bbd

File tree

5 files changed

+14
-26
lines changed

5 files changed

+14
-26
lines changed

client/components/repository/Outline/Activity.vue

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,21 @@
11
<template>
22
<div>
3-
<div class="activity-wrapper">
3+
<v-hover v-slot="{ hover }" class="activity-wrapper">
44
<div
5-
@click="selectActivity(id)"
6-
@mouseover="isHovered = true"
7-
@mouseout="isHovered = false"
5+
@mousedown="selectActivity(id)"
86
:id="`activity_${uid}`"
9-
:style="{ 'border-left-color': color }"
10-
:class="{
11-
selected: isSelected,
12-
highlighted: isHovered || isSelected
13-
}"
7+
:style="{ 'border-left-color': config.color }"
8+
:class="{ selected: isSelected, highlighted: hover }"
149
class="activity">
1510
<v-btn
1611
v-if="hasSubtypes"
17-
@click.stop="toggle()"
12+
@mousedown.stop="toggle()"
1813
icon
1914
class="my-auto">
2015
<v-icon size="30" color="primary darken-3">mdi-{{ icon }}</v-icon>
2116
</v-btn>
2217
<div class="activity-name h5 my-auto text-truncate">{{ data.name }}</div>
23-
<v-spacer />
24-
<div v-show="isHighlighted" class="actions my-auto">
18+
<div v-if="isSelected || hover" class="actions my-auto">
2519
<options-toolbar
2620
:activity="{ id, uid, repositoryId, parentId, type, position, data }"
2721
class="options-toolbar my-auto" />
@@ -44,7 +38,7 @@
4438
class="options-menu" />
4539
</div>
4640
</div>
47-
</div>
41+
</v-hover>
4842
<div v-if="!isCollapsed({ uid }) && hasChildren">
4943
<draggable
5044
@update="data => reorder(data, children)"
@@ -63,11 +57,9 @@
6357
</template>
6458

6559
<script>
66-
import { mapGetters, mapMutations, mapState } from 'vuex';
60+
import { mapGetters, mapMutations } from 'vuex';
6761
import Draggable from 'vuedraggable';
6862
import filter from 'lodash/filter';
69-
import find from 'lodash/find';
70-
import { isEditable } from 'shared/activities';
7163
import OptionsMenu from '../common/ActivityOptions/Menu';
7264
import OptionsToolbar from '../common/ActivityOptions/Toolbar';
7365
import reorderMixin from './reorderMixin';
@@ -90,15 +82,10 @@ export default {
9082
data: { type: Object, required: true },
9183
activities: { type: Array, default: () => ([]) }
9284
},
93-
data: () => ({ isHovered: false }),
9485
computed: {
9586
...mapGetters('repository', ['structure', 'isCollapsed']),
96-
...mapState('repository', { outlineState: 'outline' }),
97-
config: vm => find(vm.structure, { type: vm.type }),
98-
color: vm => vm.config.color,
99-
isEditable: vm => isEditable(vm.type),
87+
config: vm => vm.structure.find(it => it.type === vm.type),
10088
isSelected: vm => vm.selectedActivity && (vm.selectedActivity.uid === vm.uid),
101-
isHighlighted: vm => vm.isHovered || vm.isSelected,
10289
isExpanded: vm => !vm.isCollapsed({ uid: vm.uid }),
10390
hasSubtypes: vm => !!size(vm.config.subLevels),
10491
hasChildren: vm => (vm.children.length > 0) && vm.hasSubtypes,
@@ -148,7 +135,7 @@ $background-color: #eceff1;
148135
line-height: 2.5rem;
149136
}
150137
151-
&.highlighted {
138+
&.selected, &.highlighted {
152139
opacity: 1;
153140
background-color: darken($background-color, 7);
154141

client/components/repository/Workflow/Overview/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ $row-background: var(--v-primary-lighten4);
121121
.overview ::v-deep {
122122
thead.v-data-table-header {
123123
tr th {
124-
background: transparent;
124+
background: #eceff1;
125125
}
126126
}
127127

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "tailor",
3-
"version": "5.0.0-rc.3",
3+
"version": "5.0.0-rc.4",
44
"codename": "twill",
55
"description": "Content authoring platform",
66
"author": "ExtensionEngine <[email protected]>",

server/shared/storage/providers/amazon.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ class Amazon {
9898
// API docs: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#deleteObjects-property
9999
deleteFiles(keys, options = {}) {
100100
const objects = keys.map(key => ({ Key: key }));
101+
if (!keys.length) return Promise.resolve();
101102
const params = Object.assign(options, { Bucket: this.bucket, Delete: { Objects: objects } });
102103
return this.client.deleteObjects(params).promise();
103104
}

0 commit comments

Comments
 (0)