Use cached_property to create Futures #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and avoid trying to access possibly non-existent event loop in init methods, which allows to construct affected classes without a running event loop fix flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #894
Also, fix one flaky test (
test_game_matchmaking_start) by fully waiting for the game to start.I took a look at other flaky tests, but I couldn't reproduce their flakiness: they had been continuing to pass.
The only flaky one which sometimes failed is
test_game_matchmaking_close_fa_and_requeue, and I believe this is happening due to@fast_forwardnot working as wished withloop.run_in_executorfutures.Removing
@fast_forwarddecorator fixes this test's flakiness, but increases runtime (from ~1 to about ~2.5 seconds), so I didn't touch that.