From 739af19e670c6be374e2480122a1a6631d68b21a Mon Sep 17 00:00:00 2001 From: Jennings Zhang Date: Mon, 13 Jan 2025 13:18:51 -0500 Subject: [PATCH] Remove setting of PORT on pfdcm with kservice Fixes error validation failed: "PORT" is a reserved environment variable See https://github.com/knative/serving/blob/3e6d275e2bc402e7f6bea0a2d0744bb4c9679c75/pkg/apis/serving/k8s_validation_test.go#L1869-L1883 --- charts/chris/Chart.yaml | 2 +- charts/chris/templates/pfdcm/pfdcm.yml | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/charts/chris/Chart.yaml b/charts/chris/Chart.yaml index eb2d9e3..6b4b338 100644 --- a/charts/chris/Chart.yaml +++ b/charts/chris/Chart.yaml @@ -17,7 +17,7 @@ keywords: icon: ./logo_chris.png type: application -version: "1.0.0-alpha.3" +version: "1.0.0-alpha.4" appVersion: "6.3.0-beta.7" maintainers: diff --git a/charts/chris/templates/pfdcm/pfdcm.yml b/charts/chris/templates/pfdcm/pfdcm.yml index bb5c597..5438999 100644 --- a/charts/chris/templates/pfdcm/pfdcm.yml +++ b/charts/chris/templates/pfdcm/pfdcm.yml @@ -8,10 +8,6 @@ {{- if (not (hasKey $values "containerPort")) -}} {{- $_ := set $values "containerPort" .Values.pfdcm.service.port -}} {{- end -}} -{{- $extraEnv := get $values "extraEnv" -}} -{{- if (not (hasKey $extraEnv "PORT" )) -}} -{{- $_ := set $extraEnv "PORT" (get $values "containerPort") -}} -{{- end -}} {{- $labels := get $values "labels" -}} {{- if (empty (get $labels "app.kubernetes.io/component")) -}}