Load mods from Version Subfolders

[TheColin21]

Hi, I think it would be great and relatively easy to implement for Fabric to load mods from subfolders of the "mods" folder named like the versions (for example 1.14.4 and 1.15).

[LemmaEOF]

The main issue with this is that, unless set up in the right way, it would remove some abstraction from Minecraft. I can think of a way to do it decently well, so I’ll maybe look into writing a PR for it.

[LemmaEOF]

Actually, it looks like GameProviders already give version numbers that could be used. This should be easier than I expected.

[coderbot16]

IMO this is an antipattern, you should instead use separate folders per instance so that you don't accidentally load a world in the wrong version and break it.

[TheColin21]

Thanks for looking into this, would be really great. Especially if it's easy to implement. This would make several Minecraft Fabric Instances via the Vanilla Launcher way easier. Am 6. Januar 2020 22:41:36 MEZ schrieb Meredith Espinosa <notifications@github.com>:

…

Actually, it looks like [`GameProvider`s already give version numbers](https://github.com/FabricMC/fabric-loader/blob/master/src/main/java/net/fabricmc/loader/game/GameProvider.java#L32) that could be used. This should be easier than I expected. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #181 (comment)

[modmuss50]

I dont think this is going to be a thing, like @coderbot16 said even the vanilla launcher allows you to create split instances that will ensure you dont load the wrong world, among a host of other issues.

Adding it isnt hard, but I think it will just cause more issues than its worth. Also note as far as im aware forge no longer does this as of 1.13 upwards.

[LemmaEOF]

yeah, it's literally a single-line fix, but it's much safer to add a new profile directory with the Vanilla launcher.

(for those who want a Loader fork with this, it's literally just adding resolver.addCandidateFinder(new DirectoryModCandidateFinder(getModsDirectory().toPath().resolve(getGameProvider().getNormalizedGameVersion()))); in the net.fabricmc.loader.FabricLoader#setup() method.)

[TheColin21]

I probably didn't think about the possible issues (especially with worlds..I almost never play offline) but just as an idea: you could add it and only enable it, if (for example) a special file is present in the mods directory something similar .. Am 6. Januar 2020 22:59:36 MEZ schrieb Meredith Espinosa <notifications@github.com>:

…

yeah, it's literally a single-line fix, but it's *much* safer to add a new profile directory with the Vanilla launcher. (for those who want a Loader fork with this, it's literally just adding `resolver.addCandidateFinder(new DirectoryModCandidateFinder(getModsDirectory().toPath().resolve(getGameProvider().getNormalizedGameVersion())));` in the `net.fabricmc.loader.FabricLoader#setup()` method.) -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #181 (comment)

[i509VCB]

Consensus has been this probably will not happen. Closing due to that decision.

[MelchiorGaspar]

too bad this is not getting implemented as it a pretty popular request and I need it as well..
I am using v1.19.0 for Survival single player and have a server I am on that allows v1.19.0 but isn't working correctly..
so having mods in sub folders would be great.. ;-) ^_^