Merge pull request #59 from FacturAPI/fix/fix-conditional-stream

Fix conditional stream

Author: javorosas

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [4.4.4] 2024-12-18
+
+### Fixed
+
+- Added try/catch to conditional import and define "stream" as external.
+
 ## [4.4.3] 2024-12-13
 
 ### Fixed

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "facturapi",
-  "version": "4.4.3",
+  "version": "4.4.4",
   "description": "Librería oficial de Facturapi. Crea CFDIs timbrados y enviados al SAT, XML y PDF",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",

package.json

@@ -42,18 +42,24 @@ const responseInterceptor = async (response: Response) => {
         if (!reader) {
           return response.body;
         }
-        const { Readable } = await import('stream');
-        return new Readable({
-          read() {
-            reader.read().then(({ done, value }) => {
-              if (done) {
-                this.push(null); // end stream
-              } else {
-                this.push(Buffer.from(value)); // push data to stream
-              }
-            });
-          },
-        });
+        try {
+          const { Readable } = await import('stream');
+          return new Readable({
+            read() {
+              reader.read().then(({ done, value }) => {
+                if (done) {
+                  this.push(null); // end stream
+                } else {
+                  this.push(Buffer.from(value)); // push data to stream
+                }
+              });
+            },
+          });
+        } catch (e) {
+          throw new Error(
+            'Node.js streams are not available in this environment. Please install the "stream" package.',
+          );
+        }
       } else {
         return response.blob();
       }

src/wrapper.ts

@@ -8,7 +8,7 @@ export default defineConfig({
       fileName: (format) => `index.${format}.js`,
     },
     rollupOptions: {
-      external: ['form-data'],
+      external: ['form-data', 'stream'],
       output: {
         exports: 'named', // Use named exports to avoid the warning
       },