Skip to content

Commit a8ccde9

Browse files
committed
some fixes
1 parent 2bf70a3 commit a8ccde9

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

examples/MQ/pixelDetector/src/PixelDigiBinSource.cxx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ Bool_t PixelDigiBinSource::ActivateObject(TObject** obj, const char* BrName)
143143
return kTRUE;
144144
}
145145

146+
void PixelDigiBinSource::Close()
147+
{
148+
fInputFile.close();
149+
}
150+
146151
void PixelDigiBinSource::Reset() {}
147152

148153
Int_t PixelDigiBinSource::CheckMaxEventNo(Int_t /*EvtEnd*/)

examples/MQ/pixelDetector/src/PixelDigiBinSource.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ class PixelDigiBinSource : public FairSource
3333
Bool_t Init() override;
3434

3535
Int_t ReadEvent(UInt_t i = 0) override;
36+
[[deprecated("Close will go away, the dtor closes resources")]] void Close() override;
3637
void Reset() override;
3738
Bool_t SpecifyRunId() override
3839
{

fairroot/base/sink/FairSink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class FairSink
4040
virtual ~FairSink();
4141

4242
virtual Bool_t InitSink() = 0;
43-
[[deprecated("Please close your resources in derived class dtor")]] virtual void Close();
43+
[[deprecated("Close will go away, the dtor closes resources")]] virtual void Close(){};
4444
virtual void Reset() = 0;
4545

4646
virtual Sink_Type GetSinkType() = 0;

fairroot/base/source/FairSource.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class FairSource : public TObject
3535
virtual Bool_t Init() = 0;
3636
virtual Int_t ReadEvent(UInt_t = 0) = 0;
3737
virtual Bool_t SpecifyRunId() = 0;
38-
[[deprecated("Please close your resources in derived class dtor")]] virtual void Close() {};
38+
[[deprecated("Close will go away, the dtor closes resources")]] virtual void Close() {};
3939
virtual void Reset() = 0;
4040
virtual Bool_t ActivateObject(TObject**, const char*) { return kFALSE; }
4141
virtual Bool_t ActivateObjectAny(void**, const std::type_info&, const char*) { return kFALSE; }

fairroot/base/steer/FairRootManager.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ class FairRootManager : public TObject
6363
0 : Branch does not exist */
6464
Int_t CheckBranch(const char* BrName);
6565

66+
[[deprecated("Close will go away, the dtor closes resources")]] void CloseSink() {}
6667
/**Create a new file and save the current TGeoManager object to it*/
6768
void CreateGeometryFile(const char* geofile);
6869
void Fill();

0 commit comments

Comments
 (0)