Skip to content

refactor(error_page): refactoring error page #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aman-FA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(error_page): refactoring error page #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/src/app/app_error_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ class AppErrorPage extends StatelessWidget {
debugShowCheckedModeBanner: false,
home: SafeArea(
child: BaseScaffold(
appBody: Column(
mainAxisSize: MainAxisSize.min,
appBody: ListView(
children: [
getWidget(),
],
Expand Down
2 changes: 1 addition & 1 deletion lib/src/widgets/common/error/location_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ class LocationErrorWidget extends StatelessWidget {
color: AppColors.kLightGrey,
),
),
Spacer(),
SizedBox(width: 8,),
Padding(
padding: const EdgeInsets.all(8),
child: Row(
Expand Down
21 changes: 12 additions & 9 deletions lib/src/widgets/common/error/unknown_error.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class UnknownErrorWidget extends StatelessWidget {
width: MediaQuery.of(context).size.width * 0.5,
),
SizedBox(
height: 50,
height: 30,
)
],
if (showErrorTitle) ...[
Expand All @@ -69,7 +69,7 @@ class UnknownErrorWidget extends StatelessWidget {
),
),
SizedBox(
height: 100,
height: 40,
)
],
Row(
Expand Down Expand Up @@ -108,13 +108,16 @@ class UnknownErrorWidget extends StatelessWidget {
height: 30,
),
if (message != null)
Text(
message ?? '',
style: messageStyle ??
TextStyle(
color: Colors.grey.shade600,
fontSize: 10,
),
Padding(
padding: const EdgeInsets.only(left: 10),
child: Text(
message ?? '',
style: messageStyle ??
TextStyle(
color: Colors.grey.shade600,
fontSize: 12,
),
),
),
],
),
Expand Down