-
Notifications
You must be signed in to change notification settings - Fork 22
Closed
Labels
good first issueGood for newcomersGood for newcomers
Milestone
Description
This is the internal nonce that's needed for createDataSet (changing to be random with FilOzone/filecoin-services#265 but currently sequential). There are 2 places where we need this afterwards:
- AddPieces - we get it in
getAddPiecesInfowhere it's one of 4 parallel calls. I think that's all we use fromviewContract.getDataSetso this would reduce that by one call. - DeletePiece - in feat: add piece deletion to storage context #285, where we need to make a dedicated call to get it before we can delete.
I don't know why we use it for these two and not just the dataSetId, but assuming that's not changing, we should just keep it when we resolve the provider and data set on create().
When #264 becomes a thing, this is just like dataSetId in that it's lazily resolved and until then it's an error to try and use it.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers
Type
Projects
Status
🎉 Done