-
Notifications
You must be signed in to change notification settings - Fork 23
chore: set minimum acceptable release age to 7 days #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BigLep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment on why this has been added?
Anyways, looks good to me.
Lets get a 👍 from @hugomrdias or @rvagg first though before merging.
rvagg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine, devs really should be doing this themselves in their own global config file (and probably also using the socket.dev pnpm and npm wrappers)
|
needs to exclude the local packages but +1 |
|
@hugomrdias "needs to exclude the local packages" - I don't think there's anything to do here, right? we don't link local packages by version, just by workspace. Or is there something special here to do that I'm missing? |
| # 10080 minutes is 7 days | ||
| minimumReleaseAge: 10080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Rod mentioned, I think workspace packages should be fine. If we do want to exclude some packages though, we can do it as follows:
| # 10080 minutes is 7 days | |
| minimumReleaseAge: 10080 | |
| # 10080 minutes is 7 days | |
| minimumReleaseAge: 10080 | |
| minimumReleaseAgeExclude: | |
| - packageName |
|
@hugomrdias can you please comment on this, you know pnpm better than I do. Do we really need to add in the local package names to |
|
i have not tested this as this is a recent feature, but i have seen repos that have the local deps excluded https://github.com/wevm/wagmi/blob/main/pnpm-workspace.yaml#L36-L44 |
Context: https://ipdx-workspace.slack.com/archives/C06CY12V83S/p1764009233782709