Skip to content

Conversation

@galargh
Copy link

@galargh galargh commented Nov 24, 2025

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment on why this has been added?

Anyways, looks good to me.

Lets get a 👍 from @hugomrdias or @rvagg first though before merging.

Copy link
Collaborator

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, devs really should be doing this themselves in their own global config file (and probably also using the socket.dev pnpm and npm wrappers)

@hugomrdias
Copy link
Collaborator

needs to exclude the local packages but +1

@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FS Dec 2, 2025
@rvagg
Copy link
Collaborator

rvagg commented Dec 5, 2025

@hugomrdias "needs to exclude the local packages" - I don't think there's anything to do here, right? we don't link local packages by version, just by workspace. Or is there something special here to do that I'm missing?

Comment on lines +14 to +15
# 10080 minutes is 7 days
minimumReleaseAge: 10080
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Rod mentioned, I think workspace packages should be fine. If we do want to exclude some packages though, we can do it as follows:

Suggested change
# 10080 minutes is 7 days
minimumReleaseAge: 10080
# 10080 minutes is 7 days
minimumReleaseAge: 10080
minimumReleaseAgeExclude:
- packageName

@rvagg
Copy link
Collaborator

rvagg commented Dec 9, 2025

@hugomrdias can you please comment on this, you know pnpm better than I do. Do we really need to add in the local package names to minimumReleaseAgeExclude to make this work? We don't version them here in our linking, so does it care? Or is it going to cause problems with publishing?

@hugomrdias
Copy link
Collaborator

i have not tested this as this is a recent feature, but i have seen repos that have the local deps excluded

https://github.com/wevm/wagmi/blob/main/pnpm-workspace.yaml#L36-L44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 Awaiting review

Development

Successfully merging this pull request may close these issues.

5 participants