Merge pull request #137 from Financial-Times/actually-remove-pingdom

NOPS-488 fully remove pingdom check

Author: alexmuller

src/checks/index.js

@@ -5,7 +5,6 @@ module.exports = {
 	responseCompare: require('./responseCompare.check'),
 	json: require('./json.check'),
 	string: require('./string.check'),
-	pingdom: require('./pingdom.check'),
 	graphiteSpike: require('./graphiteSpike.check'),
 	graphiteThreshold: require('./graphiteThreshold.check'),
 	graphiteWorking: require('./graphiteWorking.check'),

src/checks/pingdom.check.js

@@ -4,19 +4,19 @@ module.exports = {
 	description: '',
 	checks: [
 		{
-			type: 'pingdom',
+			type: 'graphiteThreshold',
 			name: 'test1',
-			checkId: '5555',
+			metric: 'next.fake.metric',
 			severity: 2,
 			businessImpact: 'blah',
 			technicalSummary: 'god knows',
 			panicGuide: 'Don\'t Panic',
 			interval: '1s'
 		},
 		{
-			type: 'pingdom',
+			type: 'graphiteThreshold',
 			name: 'test2',
-			checkId: '5656',
+			metric: 'next.fake.metric',
 			severity: 2,
 			businessImpact: 'blah',
 			technicalSummary: 'god knows',

test/fixtures/config/aggregate.js

@@ -3,10 +3,10 @@ module.exports = {
 	description: ' ',
 	checks: [
 		{
-			type: 'pingdom',
+			type: 'graphiteThreshold',
 			name: 'test',
-			checkID: '112345',
 			severity: 2,
+			metric: 'next.fake.metric',
 			businessImpact: 'blah',
 			technicalSummary: 'god knows',
 			panicGuide: 'Don\'t Panic',

test/fixtures/config/paywall.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const expect = require('chai').expect;
-const PingdomCheck = require('../src/checks/').pingdom;
+const GraphiteThresholdCheck = require('../src/checks/').graphiteThreshold;
 
 describe('Healthchecks', function(){
 
@@ -31,7 +31,7 @@ describe('Healthchecks', function(){
 
 	it('Should create new checks as described in the config', function(){
 
-		expect(healthchecks.checks[0]).to.be.an.instanceOf(PingdomCheck);
+		expect(healthchecks.checks[0]).to.be.an.instanceOf(GraphiteThresholdCheck);
 	});
 
 	it("Should report its status correctly", function(){