Skip to content

Commit 4adb3de

Browse files
Merge pull request #681 from Financial-Times/CI-1362-DAC_Incorrect_Aria_Label_01
[CI-1362] show title in arial-label attribute for every share button
2 parents 71f6774 + f69dd28 commit 4adb3de

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

components/x-live-blog-post/src/ShareButtons.jsx

+6-6
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ export default ({ postId, articleUrl, title }) => {
3131
href={twitterUrl}
3232
data-trackable="twitter"
3333
>
34-
<span className="o-share__text" aria-label={`Share ${title} on Twitter`}>
35-
Share on Twitter (opens new window)
34+
<span className="o-share__text">
35+
Share ${title} on Twitter (opens in a new window)
3636
</span>
3737
</a>
3838
</li>
@@ -43,8 +43,8 @@ export default ({ postId, articleUrl, title }) => {
4343
href={facebookUrl}
4444
data-trackable="facebook"
4545
>
46-
<span className="o-share__text" aria-label={`Share ${title} on Facebook`}>
47-
Share on Facebook (opens new window)
46+
<span className="o-share__text">
47+
Share ${title} on Facebook (opens in a new window)
4848
</span>
4949
</a>
5050
</li>
@@ -55,8 +55,8 @@ export default ({ postId, articleUrl, title }) => {
5555
href={linkedInUrl}
5656
data-trackable="linkedin"
5757
>
58-
<span className="o-share__text" aria-label={`Share ${title} on LinkedIn`}>
59-
Share on LinkedIn (opens new window)
58+
<span className="o-share__text">
59+
Share ${title} on LinkedIn (opens in a new window)
6060
</span>
6161
</a>
6262
</li>

0 commit comments

Comments
 (0)