Skip to content

Commit 1a36c4f

Browse files
committed
chore: address review feedback
Throw an error if `firebase.json` is missing. Print a neutral tracking log after processing GAC info
1 parent f68512d commit 1a36c4f

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/index.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,12 @@ async function run() {
6464
if (existsSync("./firebase.json")) {
6565
console.log("firebase.json file found. Continuing deploy.");
6666
} else {
67-
console.warn(
67+
throw Error(
6868
"firebase.json file not found. If your firebase.json file is not in the root of your repo, edit the entryPoint option of this GitHub action."
6969
);
7070
}
7171
const gacFilename = await createGacFile(googleApplicationCredentials);
72-
if (gacFilename !== googleApplicationCredentials) {
73-
console.log(
74-
"Created a temporary file with Google Application Credentials."
75-
);
76-
}
72+
console.log("Google Application Credentials acquired.");
7773
endGroup();
7874

7975
if (configuredChannelId === "live") {

0 commit comments

Comments
 (0)