Skip to content

Commit 552fb9d

Browse files
committed
Add default implementation to TokenVisitor#complete
1 parent cc42fdb commit 552fb9d

4 files changed

Lines changed: 7 additions & 16 deletions

File tree

src/main/org/firebirdsql/jaybird/parser/SkipUsingClause.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ public void visitToken(Token token, VisitorRegistrar visitorRegistrar) {
4747
}
4848
}
4949

50-
@Override
51-
public void complete(VisitorRegistrar visitorRegistrar) {
52-
// do nothing
53-
}
54-
5550
private void pushParserState(ParserState parserState) {
5651
preservedState.addFirst(parserState);
5752
}

src/main/org/firebirdsql/jaybird/parser/StatementDetector.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,6 @@ public void visitToken(Token token, VisitorRegistrar visitorRegistrar) {
132132
}
133133
}
134134

135-
@Override
136-
public void complete(VisitorRegistrar visitorRegistrar) {
137-
// do nothing
138-
}
139-
140135
public StatementIdentification toStatementIdentification() {
141136
return new StatementIdentification(statementType, schemaToken, tableNameToken, returningClauseDetected());
142137
}

src/main/org/firebirdsql/jaybird/parser/TokenVisitor.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// SPDX-FileCopyrightText: Copyright 2021-2022 Mark Rotteveel
1+
// SPDX-FileCopyrightText: Copyright 2021-2026 Mark Rotteveel
22
// SPDX-License-Identifier: LGPL-2.1-or-later
33
package org.firebirdsql.jaybird.parser;
44

@@ -28,10 +28,15 @@ public interface TokenVisitor {
2828

2929
/**
3030
* Signals that the last token was produced and the statement text was fully parsed.
31+
* <p>
32+
* The default implementation does nothing.
33+
* </p>
3134
*
3235
* @param visitorRegistrar
3336
* Visitor registrar (can be used to remove itself, or add other visitors)
3437
*/
35-
void complete(VisitorRegistrar visitorRegistrar);
38+
default void complete(VisitorRegistrar visitorRegistrar) {
39+
// do nothing
40+
}
3641

3742
}

src/test/org/firebirdsql/jaybird/parser/SqlParserTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,6 @@ public void visitToken(Token token, VisitorRegistrar visitorRegistrar) {
226226
}
227227
}
228228

229-
@Override
230-
public void complete(VisitorRegistrar visitorRegistrar) {
231-
// do nothing
232-
}
233229
}
234230

235231
}

0 commit comments

Comments
 (0)