Merge pull request #3805 from OrigamiDev-Pete/dev

Jack251970 · web-flow · commit 727390db4c75 · 2025-07-07T14:09:57.000+08:00
Use System.Version to compare versions
diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -550,8 +550,13 @@ private static string GetContainingFolderPathAfterUnzip(string unzippedParentFol
         private static bool SameOrLesserPluginVersionExists(string metadataPath)
         {
             var newMetadata = JsonSerializer.Deserialize<PluginMetadata>(File.ReadAllText(metadataPath));
+
+            if (!Version.TryParse(newMetadata.Version, out var newVersion))
+                return true; // If version is not valid, we assume it is lesser than any existing version
+
             return AllPlugins.Any(x => x.Metadata.ID == newMetadata.ID
-                          && newMetadata.Version.CompareTo(x.Metadata.Version) <= 0);
+                                       && Version.TryParse(x.Metadata.Version, out var version)
+                                       && newVersion <= version);
         }
 
         #region Public functions

Original file line number	Diff line number	Diff line change
`@@ -550,8 +550,13 @@ private static string GetContainingFolderPathAfterUnzip(string unzippedParentFol`
`550`	`550`	`private static bool SameOrLesserPluginVersionExists(string metadataPath)`
`551`	`551`	`{`
`552`	`552`	`var newMetadata = JsonSerializer.Deserialize<PluginMetadata>(File.ReadAllText(metadataPath));`
	`553`	`+`
	`554`	`+ if (!Version.TryParse(newMetadata.Version, out var newVersion))`
	`555`	`+ return true; // If version is not valid, we assume it is lesser than any existing version`
	`556`	`+`
`553`	`557`	`return AllPlugins.Any(x => x.Metadata.ID == newMetadata.ID`
`554`		`- && newMetadata.Version.CompareTo(x.Metadata.Version) <= 0);`
	`558`	`+ && Version.TryParse(x.Metadata.Version, out var version)`
	`559`	`+ && newVersion <= version);`
`555`	`560`	`}`
`556`	`561`
`557`	`562`	`#region Public functions`