Skip to content

Commit c13ee49

Browse files
jbarreaujbarreau
committed
chore: restore correct values
1 parent cdd4402 commit c13ee49

File tree

2 files changed

+89
-94
lines changed

2 files changed

+89
-94
lines changed

‎.github/actions/coverage/action.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ runs:
3232
- name: Combine reports
3333
shell: bash
3434
run: poetry --directory ./src/datasource_toolkit run find ../../coverage | xargs poetry --directory ./src/datasource_toolkit run coverage combine
35-
# && poetry --directory ./src/datasource_toolkit run coverage xml
3635
- name: Send coverage
3736
uses: paambaati/[email protected]
3837
env:

‎.github/workflows/generic.yml‎

Lines changed: 89 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -24,104 +24,100 @@ on:
2424
SLACK_WEBHOOK:
2525
required: true
2626
jobs:
27-
# TODO: uncomment
28-
# changes:
29-
# name: changes
30-
# runs-on: ubuntu-latest
31-
# outputs:
32-
# packages: ${{ steps.changes.outputs.packages }}
33-
# steps:
34-
# - uses: actions/checkout@v4
35-
# - id: changes
36-
# uses: ./.github/actions/changes
37-
# lint:
38-
# name: Linting
39-
# needs: [ changes ]
40-
# runs-on: ubuntu-latest
41-
# strategy:
42-
# matrix:
43-
# python-version: ['3.10']
44-
# current_package: ${{ fromJson(inputs.packages) }}
45-
# steps:
46-
# - name: has change in sub package
47-
# id: has_change
48-
# run: |
49-
# PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
50-
# echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
51-
# shell: bash
52-
# env:
53-
# PACKAGE: ${{ matrix.current_package }}
54-
# CHANGES: ${{ needs.changes.outputs.packages }}
55-
# - uses: actions/checkout@v4
56-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
57-
# - id: lint
58-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
59-
# uses: ./.github/actions/linting
60-
# with:
61-
# python-version: ${{ matrix.python-version }}
62-
# current_package: ${{ matrix.current_package }}
63-
# isort:
64-
# name: Isorting
65-
# needs: [ changes ]
66-
# runs-on: ubuntu-latest
67-
# strategy:
68-
# matrix:
69-
# python-version: ['3.10']
70-
# current_package: ${{ fromJson(inputs.packages) }}
71-
# steps:
72-
# - name: has change in sub package
73-
# id: has_change
74-
# run: |
75-
# PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
76-
# echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
77-
# shell: bash
78-
# env:
79-
# PACKAGE: ${{ matrix.current_package }}
80-
# CHANGES: ${{ needs.changes.outputs.packages }}
81-
# - uses: actions/checkout@v4
82-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
83-
# - id: isort
84-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
85-
# uses: ./.github/actions/isort
86-
# with:
87-
# python-version: ${{ matrix.python-version }}
88-
# current_package: ${{ matrix.current_package }}
89-
# black:
90-
# name: Black
91-
# needs: [ changes ]
92-
# runs-on: ubuntu-latest
93-
# strategy:
94-
# matrix:
95-
# python-version: ['3.10']
96-
# current_package: ${{ fromJson(inputs.packages) }}
97-
# steps:
98-
# - name: has change in sub package
99-
# id: has_change
100-
# run: |
101-
# PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
102-
# echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
103-
# shell: bash
104-
# env:
105-
# PACKAGE: ${{ matrix.current_package }}
106-
# CHANGES: ${{ needs.changes.outputs.packages }}
107-
# - uses: actions/checkout@v4
108-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
109-
# - id: isort
110-
# if: ${{ steps.has_change.outputs.has_change != 'false' }}
111-
# uses: ./.github/actions/black
112-
# with:
113-
# python-version: ${{ matrix.python-version }}
114-
# current_package: ${{ matrix.current_package }}
27+
changes:
28+
name: changes
29+
runs-on: ubuntu-latest
30+
outputs:
31+
packages: ${{ steps.changes.outputs.packages }}
32+
steps:
33+
- uses: actions/checkout@v4
34+
- id: changes
35+
uses: ./.github/actions/changes
36+
lint:
37+
name: Linting
38+
needs: [ changes ]
39+
runs-on: ubuntu-latest
40+
strategy:
41+
matrix:
42+
python-version: ['3.10']
43+
current_package: ${{ fromJson(inputs.packages) }}
44+
steps:
45+
- name: has change in sub package
46+
id: has_change
47+
run: |
48+
PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
49+
echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
50+
shell: bash
51+
env:
52+
PACKAGE: ${{ matrix.current_package }}
53+
CHANGES: ${{ needs.changes.outputs.packages }}
54+
- uses: actions/checkout@v4
55+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
56+
- id: lint
57+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
58+
uses: ./.github/actions/linting
59+
with:
60+
python-version: ${{ matrix.python-version }}
61+
current_package: ${{ matrix.current_package }}
62+
isort:
63+
name: Isorting
64+
needs: [ changes ]
65+
runs-on: ubuntu-latest
66+
strategy:
67+
matrix:
68+
python-version: ['3.10']
69+
current_package: ${{ fromJson(inputs.packages) }}
70+
steps:
71+
- name: has change in sub package
72+
id: has_change
73+
run: |
74+
PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
75+
echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
76+
shell: bash
77+
env:
78+
PACKAGE: ${{ matrix.current_package }}
79+
CHANGES: ${{ needs.changes.outputs.packages }}
80+
- uses: actions/checkout@v4
81+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
82+
- id: isort
83+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
84+
uses: ./.github/actions/isort
85+
with:
86+
python-version: ${{ matrix.python-version }}
87+
current_package: ${{ matrix.current_package }}
88+
black:
89+
name: Black
90+
needs: [ changes ]
91+
runs-on: ubuntu-latest
92+
strategy:
93+
matrix:
94+
python-version: ['3.10']
95+
current_package: ${{ fromJson(inputs.packages) }}
96+
steps:
97+
- name: has change in sub package
98+
id: has_change
99+
run: |
100+
PACKAGE_NAME=$(echo $PACKAGE | cut -d'/' -f3)
101+
echo "has_change=$(echo $CHANGES | jq -r .$PACKAGE_NAME)" >> $GITHUB_OUTPUT
102+
shell: bash
103+
env:
104+
PACKAGE: ${{ matrix.current_package }}
105+
CHANGES: ${{ needs.changes.outputs.packages }}
106+
- uses: actions/checkout@v4
107+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
108+
- id: isort
109+
if: ${{ steps.has_change.outputs.has_change != 'false' }}
110+
uses: ./.github/actions/black
111+
with:
112+
python-version: ${{ matrix.python-version }}
113+
current_package: ${{ matrix.current_package }}
115114
test:
116115
name: Test
117-
# TODO
118-
# needs: [isort, lint, black]
116+
needs: [isort, lint, black]
119117
runs-on: ubuntu-latest
120118
strategy:
121119
matrix:
122-
python-version: ['3.10']
123-
# TODO: restore python3.12
124-
# python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
120+
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
125121
current_package: ${{ fromJson(inputs.packages) }}
126122
steps:
127123
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)