Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with @glimmer/[email protected] #240

Open
gzurbach opened this issue Nov 25, 2024 · 1 comment
Open

Issue with @glimmer/[email protected] #240

gzurbach opened this issue Nov 25, 2024 · 1 comment

Comments

@gzurbach
Copy link
Contributor

gzurbach commented Nov 25, 2024

Dependabot is attempting to upgrade @glimmer/syntax from version 0.92.3 to 0.93.0 in our Ember app.

However, the build fails due to an issue with ember-ast-helpers, a dependency of ember-fontawesome, which hasn’t been updated in 7 years.

Specifically, ember-ast-helpers fails to import @glimmer/syntax:

ember build --environment=production

require() of ES Module /home/runner/work/webapp/webapp/node_modules/@glimmer/syntax/dist/prod/index.js from /home/runner/work/webapp/webapp/node_modules/ember-ast-helpers/build-time-component.js not supported.

Instead change the require of index.js in /home/runner/work/webapp/webapp/node_modules/ember-ast-helpers/build-time-component.js to a dynamic import() which is available in all CommonJS modules.

I reported this problem in the ember-ast-helpers repository, but as the package appears to be abandoned, it should be replaced in this project with a suitable alternative.

Version: @fortawesome/[email protected]

@mkszepp
Copy link
Contributor

mkszepp commented Dec 12, 2024

The best way is to get a release of the addon as v2 addon... its braking, but the only way to hold this addon in near future in ember apps which are making updates regulary...
Patching current version will maybe solve this issue for now, but next issue will be come, because there are also other dependencies outdated...

As note... the PR for v2 is ready #239 and has dropped nearly all dependencies... we are just waiting to get a review for that PR, but @robmadole has told me in PR, that we need to wait, because the roadmap of FA team is large...
Hopefully we can get a release of a modern addon in near future

Edit:
I think the issue was solved for now in @glimmer/syntax v0.93.1 or?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants