Skip to content

Commit 8e9805f

Browse files
authored
feat: Added missing MidiControlChangeNumber definitions (#260)
* Added missing MidiControlChangeNumber definitions * Fixed duplicate enum * Added keywords for new definitions
1 parent 1944aca commit 8e9805f

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

keywords.txt

+11
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,18 @@ GeneralPurposeController1 LITERAL1
146146
GeneralPurposeController2 LITERAL1
147147
GeneralPurposeController3 LITERAL1
148148
GeneralPurposeController4 LITERAL1
149+
BankSelectLSB LITERAL1
150+
ModulationWheelLSB LITERAL1
151+
BreathControllerLSB LITERAL1
152+
FootControllerLSB LITERAL1
153+
PortamentoTimeLSB LITERAL1
149154
DataEntryLSB LITERAL1
155+
ChannelVolumeLSB LITERAL1
156+
BalanceLSB LITERAL1
157+
PanLSB LITERAL1
158+
ExpressionControllerLSB LITERAL1
159+
EffectControl1LSB LITERAL1
160+
EffectControl2LSB LITERAL1
150161
Sustain LITERAL1
151162
Portamento LITERAL1
152163
Sostenuto LITERAL1

src/midi_Defs.h

+16-1
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,22 @@ enum MidiControlChangeNumber: uint8_t
164164
GeneralPurposeController2 = 17,
165165
GeneralPurposeController3 = 18,
166166
GeneralPurposeController4 = 19,
167-
167+
// CC20 to CC31 undefined
168+
BankSelectLSB = 32,
169+
ModulationWheelLSB = 33,
170+
BreathControllerLSB = 34,
171+
// CC35 undefined
172+
FootControllerLSB = 36,
173+
PortamentoTimeLSB = 37,
168174
DataEntryLSB = 38,
175+
ChannelVolumeLSB = 39,
176+
BalanceLSB = 40,
177+
// CC41 undefined
178+
PanLSB = 42,
179+
ExpressionControllerLSB = 43,
180+
EffectControl1LSB = 44,
181+
EffectControl2LSB = 45,
182+
// CC46 to CC63 undefined
169183

170184
// Switches ----------------------------------------------------------------
171185
Sustain = 64,
@@ -203,6 +217,7 @@ enum MidiControlChangeNumber: uint8_t
203217
NRPNMSB = 99, ///< Non-Registered Parameter Number (MSB)
204218
RPNLSB = 100, ///< Registered Parameter Number (LSB)
205219
RPNMSB = 101, ///< Registered Parameter Number (MSB)
220+
// CC102 to CC119 undefined
206221

207222
// Channel Mode messages ---------------------------------------------------
208223
AllSoundOff = 120,

0 commit comments

Comments
 (0)