MIDI_CREATE_DEFAULT_INSTANCE on RP2040?

[diyelectromusic]

I think MIDI_CREATE_DEFAULT_INSTANCE for an RP2040 based build is dropping through to use:

MIDI_CREATE_INSTANCE(HardwareSerial, Serial,  MIDI)

But I think (at least in the unofficial Arduino core) Serial is mapped onto USB and Serial1 and Serial2 are UART0 and UART1.

So when using the Pico SDK USB stack, Serial compiles, but it is sending MIDI to the USB CDC not the UART. But when Using the Adafruit TinyUSB stack Serial no longer compiles at all.

Either way, I'm finding I have to use

MIDI_CREATE_INSTANCE(HardwareSerial, Serial1,  MIDI)

directly in both cases to get "proper" serial MIDI.

So should RP2040 be added to the list of devices using Serial1 in the default in serialMIDI.h?

Kevin

[franky47]

So should RP2040 be added to the list of devices using Serial1 in the default in serialMIDI.h?

Sounds good, would you like to open a PR?