Fix filename when saving a shared file

[tom93]

From the commit message:

Previously, the code used the last path component of the content URI, but that isn't necessarily the filename -- it can be a numeric ID.

Switch to the helper function getFilenameFromContentUri(), which uses ContentResolver to read the DISPLAY_NAME column. (If that fails, we fall back to the last component of the content URI as before, because we don't have anything better to use.)

Also improve the way the MIME type is determined. Previously it was just based on the file extension. Switch to first query the ContentResolver, then try the type of the Intent (which is supposed to be set to the MIME type of the data for ACTION_SEND, but may be set to "/" if the type is unknown), and only then fall back to using the file extension.

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Fix filename when saving a shared file
• Improve the way the MIME type is determined

Testing

Tested on Android 8.1 and Android 14, sharing both using Fossify File Manager and using the native Files app.

For testing, see the branch 'build/fix-filename-from-sharing-debug' of my fork (commit), which logs all the values of interest (search for lines containing "XXX" in the logcat).

Fixes the following issue(s)

• Fixes Saving a file to storage by sharing it causes loss of file name and extension #37

Acknowledgement

• I read the contribution guidelines.

[Evidlo]

Any news from the devs on getting this merged? This seems like a small change which fixes Save as usability.

[naveensingh]

It'll be merged before the next update, which is soon.

[Evidlo]

On a related note, could there be a text input for choosing the final filename? The icon is a little misleading since it is labelled Save as but there is no way to set a filename.

Thanks to the contributor and to you for maintaining Fossify. I really love these applications!

[naveensingh]

On a related note, could there be a text input for choosing the final filename? The icon is a little misleading since it is labelled Save as but there is no way to set a filename.

Yep, I'll see what can be done about that but feel free to raise it as a feature request :)

[naveensingh]

Thanks!