Run nightly variations of yaml-tests in nightly workflow (#3202)

The configuration that existed for yaml-tests used a bunch of
environment variables that we aren't setting. Change it to use the
project properties that we do set.
I removed the control for the number of threads, as I felt it would be
good to simplify the number of controls.
It also always sets and logs the seed used during tests.
Since the yaml tests (currently) are very quick, I set the iterations to
be 50x the iterations used elsewhere, but we can control it manually.

Also, to make it easier to run the nightly workflow, I set it to also
have `workflow_dispatch`

Author: ScottDugas

.github/workflows/nightly.yml

@@ -3,6 +3,7 @@ name: Nightly
 on:
   schedule:
     - cron: "0 7 * * 1-5"
+  workflow_dispatch:
 
 jobs:
   gradle:

yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/YamlExecutionContext.java

@@ -190,12 +190,7 @@ public Optional<Integer> getNightlyRepetition() {
     }
 
     public int getNumThreads() {
-        var numThreads = 1;
-        if (System.getProperties().stringPropertyNames().contains(YamlRunner.TEST_MAX_THREADS)) {
-            numThreads = Integer.parseInt(System.getProperty(YamlRunner.TEST_MAX_THREADS));
-            Assert.thatUnchecked(numThreads > 0, "Invalid number of threads provided in the YamlExecutionContext");
-        }
-        return numThreads;
+        return Runtime.getRuntime().availableProcessors() / 2;
     }
 
     boolean isDirty() {

yaml-tests/src/main/java/com/apple/foundationdb/relational/yamltests/YamlRunner.java

@@ -51,10 +51,9 @@ public final class YamlRunner {
 
     private static final Logger logger = LogManager.getLogger(YamlRunner.class);
 
-    static final String TEST_NIGHTLY = "yaml_testing_nightly";
-    static final String TEST_SEED = "yaml_testing_seed";
-    static final String TEST_NIGHTLY_REPETITION = "yaml_testing_nightly_repetition";
-    static final String TEST_MAX_THREADS = "yaml_testing_max_threads";
+    static final String TEST_NIGHTLY = "tests.nightly";
+    static final String TEST_SEED = "tests.yaml.seed";
+    static final String TEST_NIGHTLY_REPETITION = "tests.yaml.iterations";
 
     @Nonnull
     private final String resourcePath;

yaml-tests/yaml-tests.gradle

@@ -1,6 +1,3 @@
-import java.util.jar.JarFile
-import java.util.regex.Matcher
-
 /*
  * yaml-tests.gradle
  *
@@ -21,6 +18,10 @@ import java.util.regex.Matcher
  * limitations under the License.
  */
 
+import java.util.concurrent.ThreadLocalRandom
+import java.util.jar.JarFile
+import java.util.regex.Matcher
+
 apply from: rootProject.file('gradle/proto.gradle')
 
 project.tasks.named("processResources") {
@@ -185,26 +186,20 @@ mixedModeTest {
 test {
     dependsOn "serverJars"
     systemProperty("yaml_testing_external_server", project.layout.buildDirectory.dir('externalServer').get().asFile)
-    // These are the system properties that are looked at by the YamlTesting framework to initialize the execution context
-    var isNightly = System.getenv("COM_APPLE_FOUNDATIONDB_RELATIONAL_YAMLTESTS_NIGHTLY")
-    if (isNightly != null) {
-        systemProperty("yaml_testing_nightly", isNightly);
-    }
-    var seed = System.getenv("COM_APPLE_FOUNDATIONDB_RELATIONAL_YAMLTESTS_SEED")
-    if (seed != null) {
-        systemProperty("yaml_testing_seed", Long.parseLong(seed))
-    }
-    var maxThreads = System.getenv("COM_APPLE_FOUNDATIONDB_RELATIONAL_YAMLTESTS_MAX_THREADS")
-    if (maxThreads != null) {
-        systemProperty("yaml_testing_max_threads", Integer.parseInt(maxThreads))
+    def seed
+    if (project.hasProperty('tests.yaml.seed')) {
+        seed = Long.parseLong(project.getProperty('tests.yaml.seed'))
     } else {
-        systemProperty("yaml_testing_max_threads", (int) (Runtime.runtime.availableProcessors() / 2))
+        seed = ThreadLocalRandom.current().nextLong();
     }
-    var nightlyRepetitions = System.getenv("COM_APPLE_FOUNDATIONDB_RELATIONAL_YAMLTESTS_NIGHTLY_REPETITION")
-    if (nightlyRepetitions != null) {
-        systemProperty("yaml_testing_nightly_repetition", Integer.parseInt(nightlyRepetitions))
-    } else {
-        systemProperty("yaml_testing_nightly_repetition", 100)
+    println("Using seed for yaml-tests: ${seed}")
+    systemProperty('tests.yaml.seed', seed)
+    if (project.hasProperty('tests.yaml.iterations')) {
+        systemProperties['tests.yaml.iterations'] = project.getProperty('tests.yaml.iterations')
+    } else if (project.hasProperty('tests.iterations')) {
+        // The yaml tests are quite fast now, lets put a lot more repetition on the queries, if it gets larger
+        // we may want to decrease this multiplying factor.
+        systemProperties['tests.yaml.iterations'] = Integer.parseInt(project.getProperty('tests.iterations')) * 20
     }
 }