fwk: Use macros to define auto ALS levels

Just a refactoring, shouldn't change behavior.

BUG=Reviewing changes and I see many magic numbers
BRANCH=fwk-main
TEST=Check auto ALS brightness of power button and keyboard backlight

Signed-off-by: Daniel Schaefer <[email protected]>
(cherry picked from commit 89d66a0582b4abeb79015d7f77e01bc7dff35c71)

Author: JohnAZoidberg

zephyr/program/framework/include/led.h

@@ -25,12 +25,21 @@
 #define PINS_ARRAY(id) DT_CAT(PINS_ARRAY_, id)
 #define DATA_NODE(node_id) DT_CAT(DATA_NODE_, node_id)
 
+/* Above this threshold (in lux) power button brightness is high is off, else on */
+#define FP_LED_HIGH_ALS_THRESH 130
+#define FP_LED_MED_ALS_THRESH 100
+#define FP_LED_MED_LOW_ALS_THRESH 70
+#define FP_LED_LOW_ALS_THRESH 40
+
 #define FP_LED_HIGH 55
 #define FP_LED_MEDIUM 40
 #define FP_LED_MEDIUM_LOW 28
 #define FP_LED_LOW 15
 #define FP_LED_ULTRA_LOW 8
 
+/* Above this threshold (in lux) keyboard backlight is off, else on */
+#define KB_BL_THRESHOLD 5
+
 enum led_color {
 	LED_OFF,
 	LED_RED,

zephyr/program/framework/src/led.c

@@ -164,21 +164,23 @@ static int als_lux_get(void)
 	uint16_t real_illuminance = *(uint16_t *)host_get_memmap(EC_MEMMAP_ALS);
 	timestamp_t now = get_time();
 
-	/*
-	 * before als_task stable return data (als.c common)
-	 * keep 2 second of the lightness to default high
-	 **/
 	if (chipset_in_state(CHIPSET_STATE_ON) && !als_stable) {
 		if (now.val > als_init_deadline.val + 2 * SECOND) {
 			als_stable = true;
 			als_init_deadline.val = 0;
 		}
-		real_illuminance = 1000;
+		/*
+		 * before ALS returns stable data (als.c common)
+		 * keep 2 second of the lightness to default high
+		 * power button brightness
+		 **/
+		real_illuminance = FP_LED_HIGH_ALS_THRESH + 1;
 	} else if (chipset_in_state(CHIPSET_STATE_ANY_OFF)) {
 		als_init_deadline.val = now.val;
 		if (als_stable) {
 			als_stable = false;
-			real_illuminance = 10;
+			/* Default keyboard backlight to off */
+			real_illuminance = KB_BL_THRESHOLD + 1;
 			/* clear als data and set default level for next time bootup */
 			*(uint16_t *)host_get_memmap(EC_MEMMAP_ALS) = 0;
 			system_set_bbram(SYSTEM_BBRAM_IDX_FP_LED_LEVEL, FP_LED_HIGH);
@@ -232,7 +234,7 @@ void auto_als_led_brightness(void)
 		chipset_in_state(CHIPSET_STATE_ON)) {
 		last_kbbl_led_brightness = kblight_get();
 
-		if (als_lux > 5)
+		if (als_lux > KB_BL_THRESHOLD)
 			kb_brightness = KEYBOARD_BL_BRIGHTNESS_OFF;
 		else
 			kb_brightness = KEYBOARD_BL_BRIGHTNESS_ULT_LOW;
@@ -252,13 +254,13 @@ void auto_als_led_brightness(void)
 
 	if (fp_led_auto_is_enable() &&
 		chipset_in_state(CHIPSET_STATE_ON)) {
-		if (als_lux > 130)
+		if (als_lux > FP_LED_HIGH_ALS_THRESH)
 			led_brightness = FP_LED_HIGH;
-		else if (als_lux > 100)
+		else if (als_lux > FP_LED_MED_ALS_THRESH)
 			led_brightness = FP_LED_MEDIUM;
-		else if (als_lux > 70)
+		else if (als_lux > FP_LED_MED_LOW_ALS_THRESH)
 			led_brightness = FP_LED_MEDIUM_LOW;
-		else if (als_lux > 40)
+		else if (als_lux > FP_LED_LOW_ALS_THRESH)
 			led_brightness = FP_LED_LOW;
 		else
 			led_brightness = FP_LED_ULTRA_LOW;