Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FreeCAD-addons] Reinforcement → RebarCommands (toolbar) #135

Open
kaktusus opened this issue May 8, 2022 · 11 comments
Open

[FreeCAD-addons] Reinforcement → RebarCommands (toolbar) #135

kaktusus opened this issue May 8, 2022 · 11 comments

Comments

@kaktusus
Copy link
Contributor

kaktusus commented May 8, 2022

OS: Debian GNU/Linux bookworm/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.28793 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 5386d4e)
Hash: 5386d4ed864cd03edd026e1d3d128cccedf568df
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: Polish/Poland (pl_PL)
Installed mods: 
...

Tooltips do not have translations in the GUI.

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

  1. `

obraz

The toolbar also has no translation.
obraz
obraz

  1. RebarCommands- no string in Crowdin.
    https://crowdin.com/translate/freecad-addons/32161/en-pl?filter=basic&value=0#q=RebarCommands

I must say that the icons of reinforcement are awesome.
I noticed the lack of translations in Arch workbench.

@kaktusus
Copy link
Contributor Author

kaktusus commented Jul 1, 2023

still needs attention.

@luzpaz
Copy link
Collaborator

luzpaz commented Jul 25, 2023

CC @amrit3701

hasecilu added a commit to hasecilu/FreeCAD-Reinforcement that referenced this issue Mar 1, 2024
I don't know the current method to maintain the translations on this WB but
it seems that there are some problems with some strings, so this script
aims to fix that.

- Add bash script to include marked strings on translation files (*.ts)
  - Read from `.ui` files
  - Read from `.py` files

Fix:
- FreeCAD/FreeCAD-translations#135
- FreeCAD/FreeCAD-translations#136
hasecilu added a commit to hasecilu/FreeCAD-Reinforcement that referenced this issue Mar 1, 2024
I don't know the current method to maintain the translations on this WB but
it seems that there are some problems with some strings, so this script
aims to fix that.

- Add bash script to include marked strings on translation files (*.ts)
  - Read from `.ui` files
  - Read from `.py` files

Fix:
- FreeCAD/FreeCAD-translations#135
- FreeCAD/FreeCAD-translations#136
hasecilu added a commit to hasecilu/FreeCAD-Reinforcement that referenced this issue Mar 2, 2024
I don't know the current method to maintain the translations on this WB but
it seems that there are some problems with some strings, so this script
aims to fix that.

- Add bash script to include marked strings on translation files (*.ts)
  - Read from `.ui` files
  - Read from `.py` files
- Make WB name and tooltip translatable

Fix:
- FreeCAD/FreeCAD-translations#135
- FreeCAD/FreeCAD-translations#136
hasecilu added a commit to hasecilu/FreeCAD-Reinforcement that referenced this issue Mar 2, 2024
I don't know the current method to maintain the translations on this WB but
it seems that there are some problems with some strings, so this script
aims to fix that.

- Add bash script to include marked strings on translation files (*.ts)
  - Read from `.ui` files
  - Read from `.py` files
- Make WB name and tooltip translatable

Fix:
- FreeCAD/FreeCAD-translations#135
- FreeCAD/FreeCAD-translations#136
amrit3701 pushed a commit to amrit3701/FreeCAD-Reinforcement that referenced this issue Mar 5, 2024
I don't know the current method to maintain the translations on this WB but
it seems that there are some problems with some strings, so this script
aims to fix that.

- Add bash script to include marked strings on translation files (*.ts)
  - Read from `.ui` files
  - Read from `.py` files
- Make WB name and tooltip translatable

Fix:
- FreeCAD/FreeCAD-translations#135
- FreeCAD/FreeCAD-translations#136
@kaktusus
Copy link
Contributor Author

kaktusus commented Mar 6, 2024

vokoscreenNG-2024-03-06_18-39-13.webm

😉

@kaktusus
Copy link
Contributor Author

All translations have started to work.
The only thing left to do was to translate the name of the toolbar.

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 10, 2024

So basically what remains is #313 ?

@kaktusus
Copy link
Contributor Author

Currently this workbench is spoiling BIM, there is a lot of work to be done.

@luzpaz
Copy link
Collaborator

luzpaz commented Sep 10, 2024

spoiling ? How so ? Does the Reinforcement dev know this ?

@hasecilu
Copy link

hasecilu commented Sep 10, 2024

spoiling ? How so ? Does the Reinforcement dev know this ?

Just opened this yesterday but I don't know how to fix: amrit3701/FreeCAD-Reinforcement#220

@kaktusus
Copy link
Contributor Author

spoiling ? How so ? Does the Reinforcement dev know this ?

This is not a new problem.
I am sure Yorik has spoken to the author about this ...

@yorikvanhavre
Copy link
Member

Can you have a look here @amrit3701 ?

@amrit3701
Copy link
Member

Apologies for the delayed response. I just returned from vacation and will resolve the issue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants