Fix phpstan issues

Author: iTearo

src/ClickHouseMetadataProvider.php

@@ -25,6 +25,7 @@
 use Doctrine\DBAL\Schema\Metadata\PrimaryKeyConstraintColumnRow;
 use Doctrine\DBAL\Schema\Metadata\TableColumnMetadataRow;
 use Doctrine\DBAL\Schema\Metadata\TableMetadataRow;
+use Doctrine\DBAL\Schema\Metadata\ViewMetadataRow;
 
 use function implode;
 use function sprintf;
@@ -252,7 +253,7 @@ public function getAllViews(): iterable
         $sql = "SELECT name, create_table_query FROM system.tables WHERE database = ? AND engine = 'View' ORDER BY name";
 
         foreach ($this->connection->iterateNumeric($sql, [$this->databaseName]) as $row) {
-            yield new ClickHouseViewMetadataRow(null, $row[0], $row[1]);
+            yield new ViewMetadataRow(null, $row[0], $row[1]);
         }
     }
 

src/ClickHousePlatform.php

@@ -486,6 +486,18 @@ public function getCommentOnColumnSQL(string $tableName, string $columnName, str
      */
     protected function _getCreateTableSQL(string $name, array $columns, array $options = []): array
     {
+        /** @var array{
+         *     engine: string|null,
+         *     uniqueConstraints: array|null,
+         *     indexes: array|null,
+         *     indexGranularity: int|null,
+         *     eventDateProviderColumn: string|null,
+         *     eventDateColumn: string|null,
+         *     primary: array|null,
+         *     samplingExpression: string|null,
+         *     versionColumn: string|null,
+         * } $options
+         */
         $engine        = !empty($options['engine']) ? $options['engine'] : 'ReplacingMergeTree';
         $engineOptions = '';
 
@@ -544,7 +556,7 @@ protected function _getCreateTableSQL(string $name, array $columns, array $optio
                     !($columns[$options['eventDateProviderColumn']]['type'] instanceof DecimalType) &&
                     (
                         !($columns[$options['eventDateProviderColumn']]['type'] instanceof StringType) ||
-                        $columns[$options['eventDateProviderColumn']]['fixed']
+                        $columns[$options['eventDateProviderColumn']]['fixed'] // @phpstan-ignore offsetAccess.notFound
                     )
                 ) {
                     throw new \Exception(
@@ -656,7 +668,7 @@ protected function _getCreateTableSQL(string $name, array $columns, array $optio
         $sql[] = sprintf(
             'CREATE TABLE %s (%s) ENGINE = %s%s',
             $name,
-            $this->getColumnDeclarationListSQL($columns),
+            $this->getColumnDeclarationListSQL(array_values($columns)),
             $engine,
             $engineOptions
         );

src/ClickHouseViewMetadataRow.php

@@ -25,13 +25,12 @@
 use Doctrine\DBAL\Schema\Metadata\TableMetadataRow;
 use FOD\DBALClickHouse\ClickHouseMetadataProvider;
 use FOD\DBALClickHouse\ClickHousePlatform;
-use FOD\DBALClickHouse\ClickHouseViewMetadataRow;
 use PHPUnit\Framework\TestCase;
 
 /**
  * ClickHouse DBAL test class. Testing work with public methods of FOD\DBALClickHouse\ClickHouseMetadataProvider class
  */
-class MetadataProviderTest extends TestCase
+class ClickHouseMetadataProviderTest extends TestCase
 {
     private ClickHouseMetadataProvider $metadataProvider;
     private Connection $connection;
@@ -40,9 +39,9 @@ public function setUp(): void
     {
         $this->connection = CreateConnectionTest::createConnection();
         $platform = $this->connection->getDatabasePlatform();
-        
+
         $this->metadataProvider = new ClickHouseMetadataProvider($this->connection, $platform);
-        
+
         // Create test tables for testing
         $this->createTestTables();
     }
@@ -108,7 +107,7 @@ public function testGetAllTableNames(): void
             $this->assertNull($row->getSchemaName());
             $this->assertIsString($row->getTableName());
             $this->assertEmpty($row->getOptions());
-            
+
             if ($row->getTableName() === 'test_metadata_table') {
                 $testTableFound = true;
             }
@@ -136,7 +135,7 @@ public function testGetTableColumnsForAllTables(): void
             $this->assertNull($row->getSchemaName());
             $this->assertSame('test_metadata_table', $row->getTableName());
             $this->assertNotNull($row->getColumn());
-            
+
             $column = $row->getColumn();
             $this->assertIsString($column->getName());
             $this->assertNotNull($column->getType());
@@ -164,7 +163,7 @@ public function testGetTableColumnsForTable(): void
             $this->assertNull($row->getSchemaName());
             $this->assertSame('test_metadata_table', $row->getTableName());
             $this->assertNotNull($row->getColumn());
-            
+
             $column = $row->getColumn();
             $columnNames[] = $column->getName();
         }
@@ -279,7 +278,7 @@ public function testGetTableOptionsForAllTables(): void
             $this->assertNull($row->getSchemaName());
             $this->assertIsString($row->getTableName());
             $this->assertIsArray($row->getOptions());
-            
+
             if ($row->getTableName() === 'test_metadata_table') {
                 $testTable = $row;
             }
@@ -310,7 +309,7 @@ public function testGetTableOptionsForTable(): void
         $this->assertInstanceOf(TableMetadataRow::class, $row);
         $this->assertNull($row->getSchemaName());
         $this->assertSame('test_metadata_table', $row->getTableName());
-        
+
         $options = $row->getOptions();
         $this->assertArrayHasKey('engine', $options);
         $this->assertSame('MergeTree', $options['engine']);
@@ -326,11 +325,10 @@ public function testGetAllViews(): void
         // Find our test view
         $testView = null;
         foreach ($results as $row) {
-            $this->assertInstanceOf(ClickHouseViewMetadataRow::class, $row);
+            $this->assertInstanceOf(ViewMetadataRow::class, $row);
             $this->assertNull($row->getSchemaName());
             $this->assertIsString($row->getViewName());
-            $this->assertIsString($row->getSql());
-            
+
             if ($row->getViewName() === 'test_metadata_view') {
                 $testView = $row;
             }