Validate sidecar paths

Author: FullStackChef

src/CommunityToolkit.Aspire.Hosting.Dapr/Core/DaprDistributedApplicationLifecycleHook.cs

@@ -55,6 +55,31 @@ public async Task BeforeStartAsync(DistributedApplicationModel appModel, Cancell
 
             var sidecarOptions = sidecarOptionsAnnotation?.Options;
 
+            void ValidatePaths(DaprSidecarOptions? options)
+            {
+                if (options?.RunFile is string runFile)
+                {
+                    string runFilePath = Path.GetFullPath(Path.Combine(appHostDirectory, runFile));
+
+                    if (!File.Exists(runFilePath))
+                    {
+                        throw new FileNotFoundException($"The run file '{runFile}' could not be found.");
+                    }
+                }
+
+                if (options?.RuntimePath is string runtimePath)
+                {
+                    string runtimeDirectory = Path.GetFullPath(Path.Combine(appHostDirectory, runtimePath));
+
+                    if (!Directory.Exists(runtimeDirectory))
+                    {
+                        throw new DirectoryNotFoundException($"The runtime path '{runtimePath}' could not be found.");
+                    }
+                }
+            }
+
+            ValidatePaths(sidecarOptions);
+
             [return: NotNullIfNotNull(nameof(path))]
             string? NormalizePath(string? path)
             {

tests/dapr-shared/DaprTests.cs

@@ -166,6 +166,58 @@ public async Task WithDaprSideCarAddsAnnotationBasedOnTheSidecarAppOptions(strin
         Assert.NotNull(container.Annotations.OfType<DaprSidecarAnnotation>());
     }
 
+    [Fact]
+    public async Task WithDaprSidecar_InvalidRunFile_Throws()
+    {
+        using var builder = TestDistributedApplicationBuilder.Create();
+
+        builder.AddDapr(o =>
+        {
+            o.DaprPath = "dapr";
+        });
+
+        builder.AddContainer("name", "image")
+            .WithEndpoint("http", e =>
+            {
+                e.Port = 8000;
+                e.AllocatedEndpoint = new(e, "localhost", 80);
+            })
+            .WithDaprSidecar(new DaprSidecarOptions
+            {
+                RunFile = Guid.NewGuid().ToString("N")
+            });
+
+        using var app = builder.Build();
+
+        await Assert.ThrowsAsync<FileNotFoundException>(() => ExecuteBeforeStartHooksAsync(app, default));
+    }
+
+    [Fact]
+    public async Task WithDaprSidecar_InvalidRuntimePath_Throws()
+    {
+        using var builder = TestDistributedApplicationBuilder.Create();
+
+        builder.AddDapr(o =>
+        {
+            o.DaprPath = "dapr";
+        });
+
+        builder.AddContainer("name", "image")
+            .WithEndpoint("http", e =>
+            {
+                e.Port = 8000;
+                e.AllocatedEndpoint = new(e, "localhost", 80);
+            })
+            .WithDaprSidecar(new DaprSidecarOptions
+            {
+                RuntimePath = Guid.NewGuid().ToString("N")
+            });
+
+        using var app = builder.Build();
+
+        await Assert.ThrowsAsync<DirectoryNotFoundException>(() => ExecuteBeforeStartHooksAsync(app, default));
+    }
+
     [UnsafeAccessor(UnsafeAccessorKind.Method, Name = "ExecuteBeforeStartHooksAsync")]
     private static extern Task ExecuteBeforeStartHooksAsync(DistributedApplication app, CancellationToken cancellationToken);
 }