Skip to content

Composition of transforms #8

@hbraunDSP

Description

@hbraunDSP

As a GAMPMatlab user I made extensive use of the LinTransCompose() function (I think that was the name). This was part of the modular "Lego-like" design that I really liked about it. I'd like to work on implementing LinTransCompose() for vampyre.

The problem is that as far as I know there is in general no way to calculate the SVD of the product of two matrices short of explicitly calculating their product and then calculating the SVD of that. This would be insane in terms of memory alone for many vampyre use cases. I propose to only provide an SVD for the special case of composition of unitary matrices and set svd_avail=False for others.

The problem with this is that estim.LinEst currently requires svd_avail=True. I'm willing to take that on as well but I may need some help with it; I was mainly an AMP user and only took a cursory look under the hood.

What do you think? Is this a good direction to work?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions