Replace Moq with NSubstitute (#332)

Co-authored-by: Boris Ahrens <boris.ahrens@gdata.de>

Author: borisahrens

src/MalwareSampleExchange.Console/MalwareSampleExchange.Console.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-    <Version>0.8.1</Version>
+    <Version>0.8.2</Version>
     <Nullable>enable</Nullable>
     <LangVersion>12</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>

test/MalwareSampleExchange.Console_Test/MalwareSampleExchange.Console_Test.csproj

@@ -5,7 +5,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
-    <PackageReference Include="Moq" Version="4.17.2" />
+    <PackageReference Include="NSubstitute" Version="5.1.0" />
     <PackageReference Include="System.Linq.Async" Version="6.0.1" />
     <PackageReference Include="Testcontainers" Version="3.7.0" />
     <PackageReference Include="xunit" Version="2.7.0" />

test/MalwareSampleExchange.Console_Test/MongoDockerFixture.cs

@@ -7,11 +7,11 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
-using Moq;
 using MalwareSampleExchange.Console.Database;
 using MalwareSampleExchange.Console.Models;
 using MalwareSampleExchange.Console.SampleStorage;
 using MongoDB.Driver;
+using NSubstitute;
 using Xunit;
 
 namespace MalwareSampleExchange.Console_Test;
@@ -39,7 +39,9 @@ public MongoDockerFixture()
             .WithPortBinding(27017, true)
             .Build();
 
-        _storageHandler = new FileSampleStorageHandler(Mock.Of<ILogger<FileSampleStorageHandler>>(),
+        var logger = Substitute.For<ILogger<FileSampleStorageHandler>>();
+        
+        _storageHandler = new FileSampleStorageHandler(logger,
             new OptionsWrapper<FileStorageOptions>(new FileStorageOptions
             {
                 Path = Configuration["Storage:Path"]

test/MalwareSampleExchange.Console_Test/SampleExchangeTest.cs

@@ -8,7 +8,6 @@
 using JWT.Builder;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using Moq;
 using MalwareSampleExchange.Console.ListRequester;
 using Xunit;
 using JWT.Algorithms;
@@ -17,6 +16,7 @@
 using MalwareSampleExchange.Console.Partner;
 using MalwareSampleExchange.Console.SampleStorage;
 using Microsoft.Extensions.Hosting;
+using NSubstitute;
 
 namespace MalwareSampleExchange.Console_Test;
 
@@ -38,26 +38,26 @@ public SampleExchangeTest(MongoDockerFixture mongoDockerFixture)
 
     private static PartnerProvider CreatePartnerProvider()
     {
-        return new PartnerProvider(Mock.Of<ILogger<PartnerProvider>>(),
+        return new PartnerProvider(Substitute.For<ILogger<PartnerProvider>>(),
             new OptionsWrapper<PartnerProviderOptions>(new PartnerProviderOptions
             {
                 FilePath = Configuration["Config:FilePath"]!
-            }), Mock.Of<IHostApplicationLifetime>(), new HttpClient());
+            }), Substitute.For<IHostApplicationLifetime>(), new HttpClient());
     }
 
     private static ISampleStorageHandler CreateSampleGetter()
     {
         var options = new FileStorageOptions();
         Configuration.GetSection("Storage").Bind(options);
 
-        var sampleGetter = new FileSampleStorageHandler(Mock.Of<ILogger<FileSampleStorageHandler>>(),
+        var sampleGetter = new FileSampleStorageHandler(Substitute.For<ILogger<FileSampleStorageHandler>>(),
             new OptionsWrapper<FileStorageOptions>(options));
         return sampleGetter;
     }
 
     private ListRequester CreateListRequester(ISampleMetadataHandler? sampleMetadataReader = null)
     {
-        sampleMetadataReader ??= Mock.Of<ISampleMetadataHandler>();
+        sampleMetadataReader ??= Substitute.For<ISampleMetadataHandler>();
         var options = new ListRequesterOptions();
         Configuration.GetSection("Token").Bind(options);
         return new ListRequester(new OptionsWrapper<ListRequesterOptions>(options),