The script here is questionable

[weiyuan-jiang]

This script seems a copy from upper air. But I think it is incorrect and may do one more remapping. I am checking . @mathomp4 @biljanaorescanin

GEOS_Util/pre/remap_restart/remap_lake_landice_saltwater.py

Lines 217 to 271 in 7820b59

	"""
	source {Bin}/g5_modules
	limit stacksize unlimited
	cd {out_dir}/upper_data
	/bin/touch input.nml
	# The MERRA fvcore_internal_restarts don't include W or DZ, but we can add them by setting
	# HYDROSTATIC = 0 which means HYDROSTATIC = FALSE
	if ($?I_MPI_ROOT) then
	# intel scaling suggestions
	#--------------------------
	setenv I_MPI_ADJUST_ALLREDUCE 12
	setenv I_MPI_ADJUST_GATHERV 3
	setenv I_MPI_SHM_HEAP_VSIZE 512
	setenv PSM2_MEMORY large
	setenv I_MPI_EXTRA_FILESYSTEM 1
	setenv I_MPI_EXTRA_FILESYSTEM_FORCE gpfs
	setenv ROMIO_FSTYPE_FORCE "gpfs:"
	endif
	set infiles = ()
	set outfils = ()
	foreach infile ( *_restart_in )
	if ( $infile == fvcore_internal_restart_in ) continue
	if ( $infile == moist_internal_restart_in ) continue
	set infiles = ( $infiles $infile )
	set outfil = `echo $infile | sed "s/restart_in/rst_out/"`
	set outfils = ($outfils $outfil)
	end
	set interp_restartsX = {Bin}/interp_restarts.x
	if ( $#infiles ) then
	set ioflag = "-input_files $infiles -output_files $outfils"
	set ftype = `file -Lb --mime-type fvcore_internal_restart_in`
	if ($ftype =~ *stream*) then
	set interp_restartsX = {Bin}/interp_restarts_bin.x
	endif
	else
	set ioflag = ""
	endif
	set drymassFLG = {drymassFLG}
	if ($drymassFLG) then
	set dmflag = ""
	else
	set dmflag = "-scalers F"
	endif
	{Bin}/esma_mpirun -np {NPE} $interp_restartsX -im {imout} -lm {nlevel} \\
	-do_hydro {hydrostatic} $ioflag $dmflag -nwriter {nwrit} {stretch_str}
	"""

[biljanaorescanin]

Is this what was just merged? https://github.com/GEOS-ESM/GEOS_Util/pull/95/files
I didn't do the testing. Maybe @mathomp4 tested this?
@sshakoor1 was working on that.

[sshakoor1]

This was not ready to merge. I'm currently out of town so I'm a bit limited in what I can do but we should probably reverse this.

[weiyuan-jiang]

we should undo this merge [(https://github.com//pull/95/files)] @mathomp4

[biljanaorescanin]

FYI @sdrabenh

[biljanaorescanin]

@sshakoor1 in general it would be nice to keep PRs that are not ready as drafts.
It will make things easier for @sdrabenh in future.

[sshakoor1]

Sorry about that

[mathomp4]

Oh. yeah. I guess it wasn't draft and @sdrabenh pulled it in. I've made a revert PR (#100) and merged that.

@sshakoor1 when you have time you can make a new draft PR for your work on the lake-landice.