debug mode exposed an error that exists in optimized mode

[biljanaorescanin]

Testing of bcs package in debug mode for NLv3 with EASE grid M09 exposed an error:
GEOS-ESM/GEOSldas#552

Summarizing comments left on #576 here, so we can merge PR where comments were left:

GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/CombineRasters.F90

Lines 343 to 347 in 9c3baa1
When line 344 is executed, Pix1 = -999 which leads to crash. It is exposed by debug mode but exists in optimized mode ( just does not crash) .

We may have to examine why it checks table 2 of pix2 but use table 1 of pix1
from @gmao-rreichle
#576 (comment)
from @atrayano:
#576 (comment)

[weiyuan-jiang]

GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/rasterize.H

Lines 141 to 153 in 1046239

	! Make sure it worked
	!--------------------
	failed=.false.
	do j=1,unr
	n = count(raster(:,j)==RASTERUNDEF)
	if(n>0) then
	print *, ' At j=',j,' there are ',n,' undefined pixels'
	failed=.true.
	end if
	enddo
	if(.not.failed) print *, 'Rasterization completed successfully'

We have seen a lot of print out like "undefined pixels". If it succeeds, "Rasterization completed successfully" would be printed out. Unfortunately, we didn't see that message for tag NL3 and M09 grid . @biljanaorescanin @gmao-rreichle @atrayano

[biljanaorescanin]

@weiyuan-jiang we either never come to that section or we never had this successful message written out. Not with any EASE grid (36,25,09,03) or with any CF (24,48,90,180,360 ...) options. I never had a run of boundary conditions that prints out "Rasterization completed successfully". Unfortunately, I can't double check in Larry's directory (was this ever run successfully?) for older BCS versions because he doesn't have saved output *.log or *.err files with his runs. But since tile files are zero diff I presume it didn't.
I compared:
/discover/nobackup/ltakacs/bcs/Icarus-NLv3/Icarus-NLv3_Ostia/CF0360x6C_CF0360x6C/CF0360x6C_CF0360x6C-Pfafstetter.til
With my file and number of tiles is the same same goes for our catchment.def files.

[gmao-rreichle]

closing. addressed with #601