Skip to content

Commit 291d702

Browse files
committed
targets/radeonsi/vdpau: convert to static/shared pipe-drivers
Similar to previous commits, this allows us to minimise some of the duplication by compacting all vdpau targets into a single library. v2: Include the radeon winsys only when there is a user for it. v3: Correcly include the winsys. Now with extra brown bag :\ Cc: Christian König <[email protected]> Signed-off-by: Emil Velikov <[email protected]> Reviewed-by: Christian König <[email protected]> Tested-by: Thomas Helland <thomashelland90 at gmail.com>
1 parent f85e7ce commit 291d702

File tree

7 files changed

+15
-79
lines changed

7 files changed

+15
-79
lines changed

configure.ac

+1-2
Original file line numberDiff line numberDiff line change
@@ -1960,7 +1960,7 @@ if test -n "$with_gallium_drivers"; then
19601960
GALLIUM_DRIVERS_DIRS="$GALLIUM_DRIVERS_DIRS radeonsi"
19611961
radeon_llvm_check "radeonsi"
19621962
require_egl_drm "radeonsi"
1963-
gallium_check_st "radeon/drm" "radeonsi/dri" "" "" "radeonsi/vdpau" "radeonsi/omx"
1963+
gallium_check_st "radeon/drm" "radeonsi/dri" "" "" "vdpau/radeonsi" "radeonsi/omx"
19641964
DRICOMMON_NEED_LIBDRM=yes
19651965
;;
19661966
xnouveau)
@@ -2224,7 +2224,6 @@ AC_CONFIG_FILES([Makefile
22242224
src/gallium/targets/r600/xvmc/Makefile
22252225
src/gallium/targets/radeonsi/dri/Makefile
22262226
src/gallium/targets/radeonsi/omx/Makefile
2227-
src/gallium/targets/radeonsi/vdpau/Makefile
22282227
src/gallium/targets/vdpau/Makefile
22292228
src/gallium/targets/xa/Makefile
22302229
src/gallium/targets/xa/xatracker.pc

install-gallium-links.mk

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ if BUILD_SHARED
55
if HAVE_COMPAT_SYMLINKS
66
all-local : .libs/install-gallium-links
77

8-
.libs/install-gallium-links : $(dri_LTLIBRARIES) $(vdpau_LTLIBRARIES) $(egl_LTLIBRARIES) $(lib_LTLIBRARIES)
8+
.libs/install-gallium-links : $(dri_LTLIBRARIES) $(egl_LTLIBRARIES) $(lib_LTLIBRARIES)
99
$(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR); \
1010
link_dir=$(top_builddir)/$(LIB_DIR)/gallium; \
1111
if test x$(egl_LTLIBRARIES) != x; then \
1212
link_dir=$(top_builddir)/$(LIB_DIR)/egl; \
1313
fi; \
1414
$(MKDIR_P) $$link_dir; \
1515
file_list=$(dri_LTLIBRARIES:%.la=.libs/%.so); \
16-
file_list+=$(vdpau_LTLIBRARIES:%.la=.libs/%.$(LIB_EXT)*); \
1716
file_list+=$(egl_LTLIBRARIES:%.la=.libs/%.$(LIB_EXT)*); \
1817
file_list+=$(lib_LTLIBRARIES:%.la=.libs/%.$(LIB_EXT)*); \
1918
for f in $$file_list; do \

src/gallium/Automake.inc

-20
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ GALLIUM_DRI_LINKER_FLAGS = \
5959
-avoid-version \
6060
$(GC_SECTIONS)
6161

62-
GALLIUM_VDPAU_LINKER_FLAGS = \
63-
-shared \
64-
-module \
65-
-no-undefined \
66-
-version-number $(VDPAU_MAJOR):$(VDPAU_MINOR) \
67-
$(GC_SECTIONS) \
68-
$(LD_NO_UNDEFINED)
69-
7062
GALLIUM_XVMC_LINKER_FLAGS = \
7163
-shared \
7264
-module \
@@ -87,9 +79,6 @@ if HAVE_LD_VERSION_SCRIPT
8779
GALLIUM_DRI_LINKER_FLAGS += \
8880
-Wl,--version-script=$(top_srcdir)/src/gallium/targets/dri.sym
8981

90-
GALLIUM_VDPAU_LINKER_FLAGS += \
91-
-Wl,--version-script=$(top_srcdir)/src/gallium/targets/vdpau/vdpau.sym
92-
9382
GALLIUM_XVMC_LINKER_FLAGS += \
9483
-Wl,--version-script=$(top_srcdir)/src/gallium/targets/xvmc.sym
9584

@@ -112,13 +101,6 @@ GALLIUM_DRI_LIB_DEPS = \
112101
$(EXPAT_LIBS) \
113102
$(GALLIUM_COMMON_LIB_DEPS)
114103

115-
GALLIUM_VDPAU_LIB_DEPS = \
116-
$(top_builddir)/src/gallium/auxiliary/libgallium.la \
117-
$(top_builddir)/src/gallium/state_trackers/vdpau/libvdpautracker.la \
118-
$(VDPAU_LIBS) \
119-
$(LIBDRM_LIBS) \
120-
$(GALLIUM_COMMON_LIB_DEPS)
121-
122104
GALLIUM_XVMC_LIB_DEPS = \
123105
$(top_builddir)/src/gallium/auxiliary/libgallium.la \
124106
$(top_builddir)/src/gallium/state_trackers/xvmc/libxvmctracker.la \
@@ -142,12 +124,10 @@ GALLIUM_WINSYS_CFLAGS = \
142124
if HAVE_MESA_LLVM
143125

144126
GALLIUM_DRI_LINKER_FLAGS += $(LLVM_LDFLAGS)
145-
GALLIUM_VDPAU_LINKER_FLAGS += $(LLVM_LDFLAGS)
146127
GALLIUM_XVMC_LINKER_FLAGS += $(LLVM_LDFLAGS)
147128
GALLIUM_OMX_LINKER_FLAGS += $(LLVM_LDFLAGS)
148129

149130
GALLIUM_DRI_LIB_DEPS += $(LLVM_LIBS)
150-
GALLIUM_VDPAU_LIB_DEPS += $(LLVM_LIBS)
151131
GALLIUM_XVMC_LIB_DEPS += $(LLVM_LIBS)
152132
GALLIUM_OMX_LIB_DEPS += $(LLVM_LIBS)
153133

src/gallium/targets/Makefile.am

-4
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,6 @@ if HAVE_DRI2
9595
SUBDIRS += radeonsi/dri
9696
endif
9797

98-
if HAVE_ST_VDPAU
99-
SUBDIRS += radeonsi/vdpau
100-
endif
101-
10298
if HAVE_ST_OMX
10399
SUBDIRS += radeonsi/omx
104100
endif

src/gallium/targets/radeonsi/vdpau/Makefile.am

-50
This file was deleted.

src/gallium/targets/radeonsi/vdpau/drm_target.c

-1
This file was deleted.

src/gallium/targets/vdpau/Makefile.am

+13
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,14 @@ endif
5050

5151
# Radeon winsys chaos
5252
if HAVE_GALLIUM_R600
53+
STATIC_TARGET_LIB_DEPS += \
54+
$(top_builddir)/src/gallium/winsys/radeon/drm/libradeonwinsys.la
55+
else
56+
if HAVE_GALLIUM_RADEONSI
5357
STATIC_TARGET_LIB_DEPS += \
5458
$(top_builddir)/src/gallium/winsys/radeon/drm/libradeonwinsys.la
5559
endif
60+
endif
5661

5762
if HAVE_GALLIUM_RADEON_COMMON
5863
STATIC_TARGET_LIB_DEPS += \
@@ -67,6 +72,14 @@ STATIC_TARGET_LIB_DEPS += \
6772
$(RADEON_LIBS)
6873
endif
6974

75+
if HAVE_GALLIUM_RADEONSI
76+
MEGADRIVERS += radeonsi
77+
STATIC_TARGET_CPPFLAGS += -DGALLIUM_RADEONSI
78+
STATIC_TARGET_LIB_DEPS += \
79+
$(top_builddir)/src/gallium/drivers/radeonsi/libradeonsi.la \
80+
$(RADEON_LIBS)
81+
endif
82+
7083
libvdpau_gallium_la_SOURCES += target.c
7184
libvdpau_gallium_la_CPPFLAGS = $(STATIC_TARGET_CPPFLAGS)
7285
libvdpau_gallium_la_LIBADD += $(STATIC_TARGET_LIB_DEPS)

0 commit comments

Comments
 (0)