Replace all sprintf with snprintf

Signed-off-by: Xiang Xiao <[email protected]>

Author: xiaoxiang781216

arch/arm/src/armv7-m/arm_systick.c

@@ -302,7 +302,7 @@ struct timer_lowerhalf_s *systick_initialize(bool coreclk,
     {
       char devname[32];
 
-      sprintf(devname, "/dev/timer%d", minor);
+      snprintf(devname, sizeof(devname), "/dev/timer%d", minor);
       timer_register(devname, (struct timer_lowerhalf_s *)lower);
     }
 

arch/arm/src/armv8-m/arm_systick.c

@@ -302,7 +302,7 @@ struct timer_lowerhalf_s *systick_initialize(bool coreclk,
     {
       char devname[32];
 
-      sprintf(devname, "/dev/timer%d", minor);
+      snprintf(devname, sizeof(devname), "/dev/timer%d", minor);
       timer_register(devname, (struct timer_lowerhalf_s *)lower);
     }
 

arch/arm/src/c5471/c5471_watchdog.c

@@ -250,8 +250,8 @@ static ssize_t wdt_read(struct file *filep, char *buffer, size_t buflen)
   wdinfo("buflen=%d\n", buflen);
   if (buflen >= 18)
     {
-      sprintf(buffer, "%08" PRIx32 " %08" PRIx32 "\n",
-              c5471_wdt_cntl, c5471_wdt_count);
+      snprintf(buffer, buflen, "%08" PRIx32 " %08" PRIx32 "\n",
+               c5471_wdt_cntl, c5471_wdt_count);
       return 18;
     }
 

arch/arm/src/phy62xx/uart.h

@@ -165,7 +165,15 @@ int hal_uart_set_tx_buf(UART_INDEX_e uart_index, uint8_t *buf,
     uint16_t size);
 int hal_uart_get_tx_ready(UART_INDEX_e uart_index);
 int hal_uart_send_buff(UART_INDEX_e uart_index, uint8_t *buff, uint16_t len);
-#define logx(...) {char tmp_str[128]; sprintf(tmp_str, __VA_ARGS__); hal_uart_send_buff(0, &tmp_str, strlen(tmp_str) + 1);}
+#define logx(...) \
+  do \
+    { \
+      char tmp_str[128]; \
+      snprintf(tmp_str, sizeof(tmp_str), __VA_ARGS__); \
+      hal_uart_send_buff(0, &tmp_str, strlen(tmp_str) + 1); \
+    } \
+  while (0)
+
 int hal_uart_send_byte(UART_INDEX_e uart_index, unsigned char data);
 void __attribute__((weak)) hal_UART0_IRQHandler(void);
 void __attribute__((weak)) hal_UART1_IRQHandler(void);

arch/arm/src/tlsr82/tlsr82_flash_mtd.c

@@ -292,13 +292,16 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf,
     {
       if (i % 16 == 0)
         {
-          off += sprintf(&print_buf[off], "0x%08x:", i);
+          snprintf(&print_buf[off],
+                   sizeof(print_buf) - off, "0x%08x:", i);
+          off += strlen(&print_buf[off]);
         }
 
-      off += sprintf(&print_buf[off], "0x%02x ", buf[i]);
-      i++;
+      snprintf(&print_buf[off],
+               sizeof(print_buf) - off, "0x%02x ", buf[i]);
+      off += strlen(&print_buf[off]);
 
-      if (i % 16 == 0)
+      if (++i % 16 == 0)
         {
           ferr("%s\n", print_buf);
           off = 0;
@@ -320,7 +323,7 @@ static void tlsr82_flash_print(const char *msg, const uint8_t *buf,
 static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv)
 {
   struct mtd_geometry_s geo;
-  int ret      = OK;
+  int ret      = 0;
   int npages   = 0;
   int i        = 0;
   int j        = 0;
@@ -329,13 +332,16 @@ static int tlsr82_flash_test(struct tlsr82_flash_dev_s *priv)
 
   /* 1. print the manufacture id and unique id */
 
-  ret = 0;
   ferr("Flash information print:\n");
   ferr("    Flash MID: 0x%08lx\n", g_flash_mid);
-  ret += sprintf(&print_buf[ret], "    Flash UID: ");
+  snprintf(&print_buf[ret],
+           sizeof(print_buf) - ret, "    Flash UID: ");
+  ret += strlen(&print_buf[ret]);
   for (i = 1; i < 16; i++)
     {
-      ret += sprintf(&print_buf[ret], "0x%x ", g_flash_uid[i]);
+      snprintf(&print_buf[ret],
+               sizeof(print_buf) - ret, "0x%x ", g_flash_uid[i]);
+      ret += strlen(&print_buf[ret]);
     }
 
   ferr("%s\n", print_buf);

arch/risc-v/src/esp32c3/esp32c3_partition.c

@@ -607,7 +607,7 @@ int esp32c3_partition_init(void)
         }
 
       strlcpy(label, (char *)info->label, sizeof(label));
-      sprintf(path, "%s%s", path_base, label);
+      snprintf(path, sizeof(path), "%s%s", path_base, label);
 
       finfo("INFO: [label]:   %s\n", label);
       finfo("INFO: [type]:    %d\n", info->type);

boards/arm/stm32/cloudctrl/src/stm32_chipid.c

@@ -63,7 +63,8 @@ const char *stm32_getchipid_string(void)
 
   for (i = 0, c = 0; i < 12; i++)
     {
-      sprintf(&cpuid[c], "%02X", getreg8(0x1ffff7e8 + 11 - i));
+      snprintf(&cpuid[c], sizeof(cpuid) - c,
+               "%02X", getreg8(0x1ffff7e8 + 11 - i));
       c += 2;
       if (i % 4 == 3)
         {

boards/arm/stm32/shenzhou/src/stm32_chipid.c

@@ -63,7 +63,8 @@ const char *stm32_getchipid_string(void)
 
   for (i = 0, c = 0; i < 12; i++)
     {
-      sprintf(&cpuid[c], "%02X", getreg8(0x1ffff7e8 + 11 - i));
+      snprintf(&cpuid[c], sizeof(cpuid) - c,
+               "%02X", getreg8(0x1ffff7e8 + 11 - i));
       c += 2;
       if (i % 4 == 3)
         {

boards/arm/stm32f7/nucleo-144/src/stm32_bringup.c

@@ -174,7 +174,7 @@ int stm32_bringup(void)
   char buf[9];
 
 #ifdef CONFIG_STM32F7_TIM1_QE
-  sprintf(buf, "/dev/qe0");
+  snprintf(buf, sizeof(buf), "/dev/qe0");
   ret = stm32_qencoder_initialize(buf, 1);
   if (ret < 0)
     {
@@ -186,7 +186,7 @@ int stm32_bringup(void)
 #endif
 
 #ifdef CONFIG_STM32F7_TIM3_QE
-  sprintf(buf, "/dev/qe2");
+  snprintf(buf, sizeof(buf), "/dev/qe2");
   ret = stm32_qencoder_initialize(buf, 3);
   if (ret < 0)
     {
@@ -198,7 +198,7 @@ int stm32_bringup(void)
 #endif
 
 #ifdef CONFIG_STM32F7_TIM4_QE
-  sprintf(buf, "/dev/qe3");
+  snprintf(buf, sizeof(buf), "/dev/qe3");
   ret = stm32_qencoder_initialize(buf, 4);
   if (ret < 0)
     {

boards/arm/stm32l4/nucleo-l432kc/src/stm32_appinit.c

@@ -316,7 +316,7 @@ int board_app_initialize(uintptr_t arg)
   index = 0;
 
 #ifdef CONFIG_STM32L4_TIM1_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 1);
   if (ret != OK)
     {
@@ -327,7 +327,7 @@ int board_app_initialize(uintptr_t arg)
 #endif
 
 #ifdef CONFIG_STM32L4_TIM2_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 2);
   if (ret != OK)
     {
@@ -338,7 +338,7 @@ int board_app_initialize(uintptr_t arg)
 #endif
 
 #ifdef CONFIG_STM32L4_TIM3_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 3);
   if (ret != OK)
     {
@@ -349,7 +349,7 @@ int board_app_initialize(uintptr_t arg)
 #endif
 
 #ifdef CONFIG_STM32L4_TIM4_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 4);
   if (ret != OK)
     {
@@ -360,7 +360,7 @@ int board_app_initialize(uintptr_t arg)
 #endif
 
 #ifdef CONFIG_STM32L4_TIM5_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 5);
   if (ret != OK)
     {
@@ -371,7 +371,7 @@ int board_app_initialize(uintptr_t arg)
 #endif
 
 #ifdef CONFIG_STM32L4_TIM8_QE
-  sprintf(buf, "/dev/qe%d", index++);
+  snprintf(buf, sizeof(buf), "/dev/qe%d", index++);
   ret = stm32l4_qencoder_initialize(buf, 8);
   if (ret != OK)
     {