Compatibility with Various ROOT Versions

[yuanxingbo]

Hi,

I'm writing to ask which ROOT version is compatible with Gambit 2.6 ?

I can sucessfully install Gambit 2.6 with ROOT 6.30/04.

However, when installing Gambit 2.6 with ROOT 6.34/06 (also for 6.34/02 and 6.32/04), the process of cmake is terminated with the following errors.

CMake Error at cmake/optional.cmake:260 (message):
  Unable to detect what flavour of C++ your installation of ROOT has
  been compiled with; please set -DWITH_ROOT=OFF.

When trying to install Gambit 2.6 with ROOT 6.30/08 (also for 6.30/06), the procedure of cmake can be finished, but the process of 'make gambit' is terminated with the following errors.

libtool: link: ( cd ".libs" && rm -f "libRestFrames.la" && ln -s "../libRestFrames.la" "libRestFrames.la" )
Making all in inc
Making all in .
Making all in RestFrames
Making all in examples
Making all in .
�[01m�[Kexample_Zll.C:31:56:�[m�[K �[01;35m�[Kwarning: �[m�[Kthis use of "defined" may not be portable [�[01;35m�[K-Wexpansion-to-defined�[m�[K]
   31 | #if defined(__MAKECINT__) || defined(__ROOTCLING__) || �[01;35m�[KCOMPILER�[m�[K
      |                                                        �[01;35m�[K^~~~~~~~�[m�[K
�[01m�[Kexample_Zll.C:31:56:�[m�[K �[01;35m�[Kwarning: �[m�[Kthis use of "defined" may not be portable [�[01;35m�[K-Wexpansion-to-defined�[m�[K]
libtool: link: /bin/c++ -I../inc -I../inc -g -Woverloaded-virtual -I/storage/jinfeng/rootinstall3/root/include -pthread -std=c++17 -m64 -std=c++17 -fPIC -fopenmp -Wall -Wextra -Wno-misleading-indentation -Wl,-rpath -Wl,/storage/jinfeng/gambit_2.6-release_2.6/build/contrib -o .libs/example_Zll.x Zll-example_Zll.o -Wl,--no-as-needed  -L/storage/jinfeng/gambit_2.6-release_2.6/build/contrib ../src/.libs/libRestFrames.so -L/storage/jinfeng/rootinstall3/root/lib -lCore -lImt -lRIO -lNet -lHist -lGraf -lGraf3d -lGpad -lROOTVecOps -lTree -lTreePlayer -lRint -lPostscript -lMatrix -lPhysics -lMathCore -lThread -lMultiProc -lROOTDataFrame -ldl -lm -lgambit_preload -fopenmp -pthread -Wl,-rpath -Wl,/storage/jinfeng/gambit_2.6-release_2.6/contrib/RestFrames-1.0.2/lib
/bin/ld: warning: libtbb.so.2, needed by /storage/jinfeng/rootinstall3/root/lib/libImt.so, not found (try using -rpath or -rpath-link)
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task::note_affinity(unsigned short)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task_group_context::cancel_group_execution()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface5::internal::task_base::destroy(tbb::task&)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `typeinfo for tbb::task'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_root_with_context_proxy::free(tbb::task&) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task_group_context::init()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_additional_child_of_proxy::allocate(unsigned long) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::get_initial_auto_partitioner_divisor()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface7::internal::isolate_within_arena(tbb::interface7::internal::delegate_base&, long)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task_group_context::~task_group_context()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_child_proxy::allocate(unsigned long) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface7::internal::task_arena_base::internal_max_concurrency(tbb::interface7::task_arena const*)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_additional_child_of_proxy::free(tbb::task&) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_continuation_proxy::allocate(unsigned long) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::throw_exception_v4(tbb::internal::exception_id)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task_group_context::is_group_execution_cancelled() const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::task_group_context::reset()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface7::internal::task_arena_base::internal_terminate()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface9::global_control::active_value(int)'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface7::internal::task_arena_base::internal_initialize()'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::interface7::internal::task_arena_base::internal_execute(tbb::interface7::internal::delegate_base&) const'
/bin/ld: /storage/jinfeng/rootinstall3/root/lib/libImt.so: undefined reference to `tbb::internal::allocate_root_with_context_proxy::allocate(unsigned long) const'
collect2: error: ld returned 1 exit status
make[6]: *** [Makefile:635: example_Zll.x] Error 1
make[5]: *** [Makefile:872: all-recursive] Error 1
make[4]: *** [Makefile:539: all-recursive] Error 1
make[3]: *** [CMakeFiles/restframes.dir/build.make:114: restframes-prefix/src/restframes-stamp/restframes-build] Error 2
make[2]: *** [CMakeFiles/Makefile2:3961: CMakeFiles/restframes.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:1256: CMakeFiles/gambit.dir/rule] Error 2
make: *** [Makefile:118: gambit] Error 2
�]0;jinfeng@dell: ~/gambit_2.6-release_2.6/build��[01;32mjinfeng@dell�[00m:�[01;34m~/gambit_2.6-release_2.6/build�[00m$ exit
exit

In this computation server, the Linux version is ubuntu 20.04. The ROOT of the various versions are installed via the pre-compiled binary.

The full terminal logs can be found in the following files.

ROOT_6.34.06.txt

ROOT_6.30.08.log

Thanks for your time.

Xing-Bo Yuan

[andrewfowlie]

Thanks for reporting these issues.

1. Flavor of ROOT

However, when installing Gambit 2.6 with ROOT 6.34/06 (also for 6.34/02 and 6.32/04), the process of cmake is terminated with the following errors.

CMake Error at cmake/optional.cmake:260 (message):
Unable to detect what flavour of C++ your installation of ROOT has
been compiled with; please set -DWITH_ROOT=OFF.

I suspect that the issue isn't the version of ROOT, bu the C++ std that your ROOT was built with. See
https://root.cern/manual/integrate_root_into_my_cmake_project/ for more background. Can you tell us the output of root-config --cflags for these versions of ROOT?

The error is coming from here

gambit_2.6/cmake/optional.cmake

Line 260 in d102ac2

message(FATAL_ERROR "${BoldRed}Unable to detect what flavour of C++ your installation of ROOT has "

It seems that we only allow these C++ standards

gambit_2.6/cmake/optional.cmake

Line 217 in d102ac2

set(std_list "17;1z;14;1y;11;0x")

However, I'd be surprised if your ROOT was compiled with C++20 so I'm not sure what might be going on.

2. Build errors

The problem is wit the ltbb library

/bin/ld: warning: libtbb.so.2, needed by /storage/jinfeng/rootinstall3/root/lib/libImt.so, not found (try using -rpath or -rpath-link)

The subsequent errors are a result of the problem reported in that warning. This seems relevant https://root-forum.cern.ch/t/usr-bin-ld-warning-libtbb-so-2-needed-by-path-gate-root-root-lib-libimt-so-not-found-try-using-rpath-or-rpath-link/35592

It might be as simple as doing

sudo apt-get install libtbb-dev

or equivalent for your platform. Let us know how it goes.

[yuanxingbo]

Thanks for your efforts and replies.

1. The output of root-config --cflags:

-pthread -std=c++17 -m64 -I/storage/ruilin/rootinstall1/root/include

The version of ROOT is 6.34/06, which is installed via the pre-compiled binary (i.e. the binary distribution in this link). From this output, it seems that the C++ standard is C++17, which is allowed in the gambit cmake file.

2. The building errors are fixed by your method. Now, gambit 2.6 can be successfully installed with ROOT 6.30/08 and 6.30/06. But, for ROOT 6.34, the issue of "flavor of ROOT" still exists, even after installing libtbb-dev.

[andrewfowlie]

Great that one problem is fixed for you.

1. Since c++17 should be fine, the logic in the cmake file is somehow failing but I can't see any obvious reason why. Looking at

   https://root.cern/manual/integrate_root_into_my_cmake_project/

   @anderkve is there a reason we don't use the ROOT_CXX_STANDARD variable? We instead use regex on the ROOT_CXX_FLAGS. This would make things simpler. In any case, we need more debugging here

2. Glad this is working for you. I think this was purely a ROOT dependency issue. That lib is a required ROOT dependency:

   https://root.cern/install/dependencies/#required-packages-1

   so I propose that we don't change GAMBIT build instructions.