Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp/size to cache file name? #4

Open
Gargaj opened this issue Mar 16, 2018 · 1 comment
Open

Add timestamp/size to cache file name? #4

Gargaj opened this issue Mar 16, 2018 · 1 comment
Labels

Comments

@Gargaj
Copy link
Owner

Gargaj commented Mar 16, 2018

I happen to have a lot of songs in my collection with the same filename but different directory (e.g. album + remaster), or I occasionally update a render of my own songs, but the waveform doesn't change.

@dr0biwan
Copy link
Collaborator

This could be a bit of a tricky one as also linking via timestamp / size could cause a re-render on metadata change which is probably ok (re-rendering is cheap enough) but it's not the most user friendliest of actions.

There's also some non-file items which can be processed where that info isn't available (I need to sync back the changes allowing. for that).

So maybe something based off of the path / location (disk or stream based) & accepting that moving will cause a re-render would be the easier option. Probably a simple hashing of the path & checking that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants