-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the MaterializeCSS dependency #1
Comments
Hi! I'll take this issue :) |
Alright, thanks for the help. I added travis ci for auto-deployment, I hope it'll help. |
Hi, Can I take this issue? |
Yeah @nuwan94 |
@nuwan94 still on it? |
Will it be better to use .css files or better go with styled-components? |
I dont know |
Repo isn't even forked by him, so you can do it @CmdEngineer |
Alright |
@GermaVinsmoke Buttons and the graph are unaffected |
The main thing is materialize-css grid - The other thing is Removing materialize-css as it is having some security issues and I think we don't need it as it is having a size of 175kB (minified) and styled-components is having a size of 45kB (minified). |
|
Suggestion: maybe use Spectre? |
Three of its javascript component are having vulnerabilities and there's no patch fix for that 🤔. So, if we're not using any of the JS Components then why to keep a module of that big size. I think that Spectre.css is cool and it'll work. |
There isn't much use of MaterializeCSS, so it's better to remove it.
The text was updated successfully, but these errors were encountered: