Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the MaterializeCSS dependency #1

Open
GermaVinsmoke opened this issue Oct 14, 2019 · 15 comments
Open

Removing the MaterializeCSS dependency #1

GermaVinsmoke opened this issue Oct 14, 2019 · 15 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@GermaVinsmoke
Copy link
Owner

There isn't much use of MaterializeCSS, so it's better to remove it.

@GermaVinsmoke GermaVinsmoke added enhancement New feature or request good first issue Good for newcomers labels Oct 14, 2019
@Erick2280
Copy link

Hi! I'll take this issue :)

@GermaVinsmoke
Copy link
Owner Author

Alright, thanks for the help. I added travis ci for auto-deployment, I hope it'll help.

@GermaVinsmoke GermaVinsmoke added the hacktoberfest To promote hacktoberfest label Oct 19, 2019
@nuwan94
Copy link

nuwan94 commented Oct 21, 2019

Hi, Can I take this issue?

@GermaVinsmoke
Copy link
Owner Author

Yeah @nuwan94

@CmdEngineer
Copy link
Contributor

CmdEngineer commented Oct 21, 2019

@nuwan94 still on it?
EDIT: If not can I take it?

@GermaVinsmoke
Copy link
Owner Author

Will it be better to use .css files or better go with styled-components?

@CmdEngineer
Copy link
Contributor

I dont know

@CmdEngineer
Copy link
Contributor

@nuwan94 still on it?
EDIT: If not can I take it?

Still asking @nuwan94

@GermaVinsmoke
Copy link
Owner Author

Repo isn't even forked by him, so you can do it @CmdEngineer

@CmdEngineer
Copy link
Contributor

Alright

@CmdEngineer
Copy link
Contributor

@GermaVinsmoke
Apparently MaterialCSS does have a big usage:
image
image

Buttons and the graph are unaffected

@GermaVinsmoke
Copy link
Owner Author

The main thing is materialize-css grid -
className="container"
className="row"
className="col "
I think we can use flexbox instead of this.
A lot of things will be solved with the help of flexbox.

The other thing is className="card". So, for this, I think it'll be better to use styled-components coz reusable Card component.

Removing materialize-css as it is having some security issues and I think we don't need it as it is having a size of 175kB (minified) and styled-components is having a size of 45kB (minified).

@CmdEngineer
Copy link
Contributor

materialize-css as it is having some security issues
how does css introduce security issues?

@CmdEngineer
Copy link
Contributor

Suggestion: maybe use Spectre?

@GermaVinsmoke
Copy link
Owner Author

materialize-css as it is having some security issues
how does css introduce security issues?

Three of its javascript component are having vulnerabilities and there's no patch fix for that 🤔. So, if we're not using any of the JS Components then why to keep a module of that big size. I think that Spectre.css is cool and it'll work.

mat

@GermaVinsmoke GermaVinsmoke removed the hacktoberfest To promote hacktoberfest label Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants