Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the dataset menu link does not clear the search filters #182

Closed
tridoxx opened this issue Aug 26, 2023 · 6 comments
Closed

Clicking the dataset menu link does not clear the search filters #182

tridoxx opened this issue Aug 26, 2023 · 6 comments
Assignees
Labels

Comments

@tridoxx
Copy link

tridoxx commented Aug 26, 2023

Hello, I have seen a problem, when selecting a theme it takes me to the datasets related to this theme, but when clicking on the themes button in the top navigation bar, it does not "clean the theme filter" the url if it changes, but the same front is kept.

  1. select the topic and the url path is: https://demo.getdkan.org/search?theme=Transportation

image

  1. inside the theme the url is https://demo.getdkan.org/search/?theme=Transportation and the datasets are filtered
    image

  2. when click the datasets button the url change but kept the filter dataset: https://demo.getdkan.org/search/

image

@janette
Copy link
Member

janette commented Aug 29, 2023

Yes definitely a bug, thanks for reporting it @tridoxx

@janette janette changed the title problem showing the datasets when entering a topic directly Clicking the dataset menu link does not clear the search filters Aug 29, 2023
@tridoxx
Copy link
Author

tridoxx commented Aug 29, 2023

yw.

@dgading
Copy link
Member

dgading commented Feb 25, 2025

I've seen this on another site. Clicking dataset again doesn't trigger a page change so the app doesn't know to re render the search component.

@dgading
Copy link
Member

dgading commented Feb 26, 2025

I've created a PR in the app that changes the functionality of how the nav link works to address this in a different way. I will make sure this is something tested when building the new site.

@TheETupper TheETupper assigned janette and unassigned dgading Feb 26, 2025
@TheETupper
Copy link

@janette assigning this one to you

@dafeder dafeder assigned dgading and unassigned janette Mar 5, 2025
@dgading
Copy link
Member

dgading commented Mar 5, 2025

Addressed in release 1.18.1 which is now npm latest and is pulled into main on data-catalog-app

@dgading dgading closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants